Read 2026-10-23
erda-project/erda: technical due diligence, read from its repository
What Borehole read in erda-project/erda's code and history at 7195c3a: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | adequate |
| Product & Engineering Maturity | adequate |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
- Releases are cut from another branch than the one surveyed
LICENSE: Relicensed: Apache-2.0 → AGPL-3.0 (2021-04-06) → Apache-2.0 (2021-08-23)
Architecture & Codebase — including AI provenance
stronginternal/apps/cmp/component-protocol/components/cmp-dashboard-workloads-list/addWorkloadFileEditor/workload_template.go is 4,862 lines, 60× this codebase's median file
adequateThe median source file here is 80 lines. 26 files exceed 1,000 lines, the largest being 4,862. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
internal/apps/cmp/component-protocol/components/cmp-dashboard-workloads-list/addWorkloadFileEditor/workload_template.go:1 — 4,862 lines (60× median) |
internal/apps/dop/providers/projectpipeline/service_impl.go:1 — 2,195 lines (27× median) |
internal/apps/dop/dicehub/release/release.service.go:1 — 1,676 lines (20× median) |
apistructs/cmp.go:1 — 1,661 lines (20× median) |
internal/core/legacy/services/project/project.go:1 — 1,643 lines (20× median) |
Engineering Process & SDLC Maturity
adequate5% of recent commits change more than 2,000 lines
adequate13 of 257 commits in the last 24 months changed over 2,000 lines of code, not counting reformatting, renames, vendored or generated code. A change that size is rarely reviewed line by line. Ask how they were reviewed, and what made them that large.
| 13 commits over 2,000 lines |
Product & Engineering Maturity
adequate215 direct dependencies in a single manifest
adequatego.mod declares 215 direct dependencies. Each one is a maintenance obligation, a supply-chain surface and a potential licence question that transfers with the asset. The count says nothing about whether any given dependency was a good choice; it says how many such choices a buyer inherits.
go.mod — 215 declared |
api/proto-go/go.mod — 6 declared |
.erda/migrations/cmdb/requirements.txt — 4 declared |
.erda/migrations/dicehub/requirements.txt — 4 declared |
26% of the code is legacy or compatibility code, the oldest 51 months old
adequate1185 of 4537 source files sit in paths named legacy, compat, shim, polyfill or deprecated, and some have been there 51 months. That is usually a migration that never finished. Ask whether finishing it is planned, and what keeping both costs.
internal/core/legacy/cache/project/project.go — legacy or compatibility code |
internal/core/legacy/common/ctxhelper/audit.go — legacy or compatibility code |
internal/core/legacy/conf/conf.go — legacy or compatibility code |
API v2 and v1 have been served together for 56 months
adequatev1 first appeared in Jan 2022, and v2 is still in the code 56 months later. Two versions mean two surfaces to secure, document and support. Ask who still calls the old one, and whether retiring it is planned.
modules/monitor/core/collector/routes.go — v2 since Jul 2021 |
modules/oap/collector/plugins/receivers/promremotewrite/provider.go — v1 since Jan 2022 |
10 files still carry code deprecated more than two years ago
adequate10 files were marked deprecated over two years ago and still are, the oldest since Mar 2021. A deprecation is a promise to remove. Ask what still depends on these, and whether removing them is scheduled.
apistructs/runtime_dto.go — deprecated since Mar 2021 |
apistructs/deployment.go — deprecated since Mar 2021 |
apistructs/member.go — deprecated since Mar 2021 |
bundle/api_asset_operation.go — deprecated since Mar 2021 |
pkg/aliyunclient/client.go — deprecated since Mar 2021 |
Releases are cut from another branch than the one surveyed
adequateThe newest release, v2.2.0, is not on the branch this survey read. The shipped product may differ from what this report describes. Survey the release branch too.
| tag v2.2.0 |
Security & Reliability Posture
adequateNone of the standard security guard rails are configured
adequateThere is no disclosure policy, no automated dependency updates, no named code owners and no pre-commit configuration. None of these is load-bearing on its own. Their collective absence says that security posture here is whatever the current team happens to remember to do, which is not a posture that survives the team changing.
| checked 5 kinds of guard rail across 9,491 tracked files; 0 present |
The build runs third-party code it does not pin
adequate7 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/ci-it-noneed.yml:46 — action pinned by tag |
.github/workflows/ci-it-noneed.yml:79 — action pinned by tag |
15 outbound calls can wait forever
adequate15 HTTP calls use a client with no timeout (Python `requests` without `timeout=`, or Go's default client). When a dependency slows down, each one holds a worker until the connection gives up, and enough of them take the service down with the dependency.
.erda/migrations/cmdb/20211014-project-quota.py:162 — outbound call without a timeout |
internal/apps/ai-proxy/route/filters/common/tts/ttsutil/download.go:31 — outbound call without a timeout |
internal/apps/ai-proxy/route/filters/response/by/service-provider/tts/volcengine-ark/response.go:135 — outbound call without a timeout |
1 SQL statement built from strings
adequate1 places in product code build SQL by formatting or joining strings rather than passing parameters. In each, what the code shows going in is a table or column name, a constant, or something the line does not show, not a request's value. Ask whether any value reaches these strings, rather than a parameter.
internal/apps/dop/dao/testcase.go:232 — SQL built from a string |
7 shell commands built from strings
adequate7 places run a command through a shell (`shell=True`, `os.system`, `exec` with a template) rather than passing arguments. Where any part comes from outside, it is command injection. Ask where each one's input comes from.
internal/pkg/extension/extension.service.go:795 — command run through a shell |
internal/pkg/extension/extension.service.go:804 — command run through a shell |
internal/pkg/extension/extension.service.go:812 — command run through a shell |
45 locked dependencies have published vulnerabilities, 35 high or critical in what ships
adequate45 of 519 locked dependencies match 130 published advisories in OSV, 64 of them rated high or critical. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version. This lockfile pins development tools alongside what ships and does not say which is which, so some of these may never reach a user.
go.mod — github.com/docker/docker v25.0.3+incompatible: GHSA-v23v-6jw2-98fq (critical), fixed in 25.0.6 |
go.mod — github.com/getkin/kin-openapi v0.76.0: GHSA-r277-6w6q-xmqw (critical), fixed in 0.144.0 |
go.mod — github.com/kedacore/keda/v2 v2.15.1: GHSA-637c-6jxx-4rwm (critical), fixed in 2.21.0 |
1 workload setting give a container the host
adequate1 places in the deployment configuration run a container privileged or in the host's network, process or IPC namespace. A compromise of that container is a compromise of the machine, and most acquirers' security reviews block it. Node agents (network, storage, monitoring) are excluded.
erda.yml:179 — privileged or host namespace |
Relicensed: Apache-2.0 → AGPL-3.0 (2021-04-06) → Apache-2.0 (2021-08-23)
adequateThe root licence changed 2 time(s). Code taken under earlier terms stays under them; check which terms any fork or customer relied on.
Observability & Operations
adequateNo error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Readiness and liveness probes are identical in 1 of 2 workloads
adequateBoth probes call the same endpoint. When a dependency slows down, the liveness probe fails with the readiness probe, so the platform restarts pods that only needed taking out of rotation, and a partial outage becomes a full one. Liveness should ask whether the process is alive; readiness whether it can serve.
cmd/monitor/extensions/loghub/log-metrics.deployment.yaml — same probe endpoint twice |
2 of 2 deployments run a single replica
adequate2 deployments set `replicas: 1`, and nothing (an autoscaler, a disruption budget) adds more. Every deploy and every node drain is downtime, and the availability the buyer inherits has a ceiling.
cmd/monitor/extensions/loghub/log-exporter.deployment.yaml — replicas: 1 |
cmd/monitor/extensions/loghub/log-metrics.deployment.yaml — replicas: 1 |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on erda-project/erda: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.