Read 2026-11-03
vespa-engine/vespa: technical due diligence, read from its repository
What Borehole read in vespa-engine/vespa's code and history at 8deb93f: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | adequate |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
AI_POLICY.md:3: states a policy on AI-generated contributions
Architecture & Codebase — including AI provenance
strongcontainer-search/src/main/java/com/yahoo/search/yql/YqlParser.java is 2,787 lines, 44× this codebase's median file
adequateThe median source file here is 63 lines. 41 files exceed 1,000 lines, the largest being 2,787. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
container-search/src/main/java/com/yahoo/search/yql/YqlParser.java:1 — 2,787 lines (44× median) |
persistence/src/vespa/persistence/conformancetest/conformancetest.cpp:1 — 2,194 lines (34× median) |
config-model/src/main/java/com/yahoo/schema/RankProfile.java:1 — 2,035 lines (32× median) |
fsa/src/vespa/fsa/fsa.h:1 — 1,978 lines (31× median) |
container-search/src/main/java/com/yahoo/search/query/SelectParser.java:1 — 1,908 lines (30× median) |
Engineering Process & SDLC Maturity
adequate4% of recent commits undo an earlier one
adequate319 of 7,777 commits in the last 24 months are reverts. Some reverting is a sign of a team that backs out safely; this much suggests change reaches the trunk before it is ready. Ask what the last few were for.
| a revert |
| a revert |
| a revert |
Product & Engineering Maturity
strong56 files still carry code deprecated more than two years ago
adequate56 files were marked deprecated over two years ago and still are, the oldest since Jun 2021. A deprecation is a promise to remove. Ask what still depends on these, and whether removing them is scheduled.
vespa-documentgen-plugin/src/main/java/com/yahoo/vespa/DocumentGenMojo.java — deprecated since Jun 2021 |
config-model-api/src/main/java/com/yahoo/config/application/api/ApplicationPackage.java — deprecated since Jun 2021 |
linguistics/src/main/java/com/yahoo/language/process/Tokenizer.java — deprecated since Jun 2021 |
model-integration/src/main/java/ai/vespa/rankingexpression/importer/configmodelview/ImportedMlModels.java — deprecated since Sep 2021 |
container-search/src/main/java/com/yahoo/search/handler/SearchHandler.java — deprecated since Sep 2021 |
Security & Reliability Posture
adequate1 credential-shaped string in the tree sit in tests, examples, documentation or local development settings
adequateStrings shaped like credentials appear only where fakes are usual: test fixtures, examples, documentation, placeholders and local stacks. They are almost always fakes. Ask someone to confirm that none of them works anywhere, because a real key in a development file is still a real key.
| private key block, where fakes are usual |
1 credential-shaped string added in the history sit in tests, examples, documentation or local development settings
adequateStrings shaped like credentials appear only where fakes are usual: test fixtures, examples, documentation, placeholders and local stacks. They are almost always fakes. Ask someone to confirm that none of them works anywhere, because a real key in a development file is still a real key.
| private key block, where fakes are usual |
1 Dockerfile runs the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
client/js/app/Dockerfile — runs as root |
3 outbound calls can wait forever
adequate3 HTTP calls use a client with no timeout (Python `requests` without `timeout=`, or Go's default client). When a dependency slows down, each one holds a worker until the connection gives up, and enough of them take the service down with the dependency.
client/go/cond_make.go:97 — outbound call without a timeout |
client/go/internal/cli/auth/auth.go:86 — outbound call without a timeout |
client/go/internal/cli/auth/auth.go:130 — outbound call without a timeout |
1 SQL statement built from strings
adequate1 places in product code build SQL by formatting or joining strings rather than passing parameters. 1 of them put a value into the string; in the rest, what the code shows going in is a table or column name, a constant, or something the line does not show. Ask whether any value reaches these strings, rather than a parameter.
container-search/src/main/java/ai/vespa/search/counting/FilterIntersectionsSearcher.java:166 — SQL built from a string |
3 locked dependencies have published vulnerabilities, 3 high or critical
adequate3 of 526 locked dependencies match 10 published advisories in OSV, 3 of them rated high or critical. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version. This lockfile pins development tools alongside what ships and does not say which is which, so some of these may never reach a user.
client/js/app/yarn.lock — brace-expansion 1.1.18: GHSA-6j4f-fj2g-mc7p (high), fixed in 1.1.19 |
client/js/app/yarn.lock — vite 8.2.1: GHSA-587h-7wmj-h5pm (high), fixed in 8.2.4 |
client/js/app/yarn.lock — minimatch 3.1.5: GHSA-g3hv-75wg-m249 (moderate), fixed in 11.0.1 |
Observability & Operations
adequateNo structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| searched 17,721 files for 10 structured logging libraries; 0 matched |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on vespa-engine/vespa: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.