Read 2026-10-04
tstack/lnav: technical due diligence, read from its repository
What Borehole read in tstack/lnav's code and history at 77a173d: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | adequate |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
Architecture & Codebase — including AI provenance
strongsrc/pugixml/pugixml.cpp is 13,030 lines, 89× this codebase's median file
adequateThe median source file here is 146 lines. 73 files exceed 1,460 lines, the largest being 13,030. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
src/pugixml/pugixml.cpp:1 — 13,030 lines (89× median) |
src/third-party/scnlib/include/scn/scan.h:1 — 9,927 lines (67× median) |
src/third-party/date/include/date/date.h:1 — 8,201 lines (56× median) |
src/third-party/doctest-root/doctest/doctest.h:1 — 7,020 lines (48× median) |
src/log_format.cc:1 — 6,871 lines (47× median) |
Engineering Process & SDLC Maturity
adequateLittle of the recent change carries a trace of review
adequateIn the last 24 months, 131 of 1,466 commits (8.9%) carry any trace of review: a merge, a pull-request reference, a Reviewed-by or Reviewed-on trailer, a Closes/Fixes reference, a maintainer's sign-off on someone else's change, or a change applied by someone other than its author. That is low but not absent. Review may happen in a workflow this history does not record; a buyer should ask how change is approved before it ships.
| 131 of 1,466 commits in the last 24 months carry review evidence; 14.0% across all 4,864 |
Almost no process scaffolding exists in the repository
adequateOf five ordinary markers — CI workflows, CODEOWNERS, a pull-request template, pre-commit hooks, contribution guidance — 1 is present: CI workflows. Branch protection itself is a GitHub setting rather than a file, so this is a reading of proxies and not of the rules themselves. What it does establish is that the process is not written down anywhere a new engineer would find it.
| 1 of 5 markers present across 4,384 tracked files |
Product & Engineering Maturity
strongNo finding.
Security & Reliability Posture
adequateNone of the standard security guard rails are configured
adequateThere is no disclosure policy, no automated dependency updates, no named code owners and no pre-commit configuration. None of these is load-bearing on its own. Their collective absence says that security posture here is whatever the current team happens to remember to do, which is not a posture that survives the team changing.
| checked 5 kinds of guard rail across 4,384 tracked files; 0 present |
1 Dockerfile runs the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
crashd/Dockerfile — runs as root |
The build runs third-party code it does not pin
adequate14 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/bins.yml:109 — action pinned by tag |
.github/workflows/bins.yml:111 — action pinned by tag |
10 locked dependencies have published vulnerabilities
adequate10 of 330 locked dependencies match 10 published advisories in OSV. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version. This lockfile pins development tools alongside what ships and does not say which is which, so some of these may never reach a user.
src/third-party/lnav-rs-ext/Cargo.lock — rand 0.8.5: GHSA-cq8v-f236-94qc (low), fixed in 0.8.6 |
src/third-party/lnav-rs-ext/Cargo.lock — anyhow 1.0.102: RUSTSEC-2026-0190 (unrated), fixed in 1.0.103 |
src/third-party/lnav-rs-ext/Cargo.lock — bincode 2.0.1: RUSTSEC-2025-0141 (unrated) |
3 vendored components with no licence
adequateThird-party code is committed into this repository without any statement of the terms it arrived under. Unknown terms are harder to deal with than inconvenient ones: an awkward licence can be complied with, an absent one cannot. Each of these needs its origin established before the code changes hands.
src/third-party/intervaltree — 1 tracked files, no licence file |
src/third-party/lnav-rs-ext — 12 tracked files, no licence file |
src/third-party/sqlite — 2 tracked files, no licence file |
Observability & Operations
adequateNo structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| C++ source is not searched: C++ programs log through printf-style calls unless they take a library, and none of the 10 searched for is referenced |
One request cannot be followed through the logs
adequateNothing in the service carries a request or correlation id, and there is no tracing. When a customer reports a failure, the log lines that belong to their request cannot be picked out from everyone else's.
| no request id, correlation id or tracing found |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on tstack/lnav: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.