Read 2026-11-03
timeplus-io/proton: technical due diligence, read from its repository
What Borehole read in timeplus-io/proton's code and history at bfab9f0: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | strong |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
.gitmodules:1: 99 submodule(s) this survey does not read: contrib/zstd, contrib/lz4, contrib/cctz
Architecture & Codebase — including AI provenance
strongCommit messages are templated rather than written
adequate37% of commit subjects are exact repeats of another subject, and subject length varies by only 22.2 characters. A log written by someone explaining their reasoning to a future reader does not look like this. The log is therefore weak evidence of intent, whatever the code is like. This was read from the most recent 50,000 commits (21 Jan 2020 to 30 Oct 2026) only; older history was not read.
| 402× 'fix' |
| 225× 'Fix build' |
| 209× 'Fix' |
src/Parsers/New/ClickHouseParser.cpp is 20,193 lines, 480× this codebase's median file
adequateThe median source file here is 42 lines. 161 files exceed 1,000 lines, the largest being 20,193. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
src/Parsers/New/ClickHouseParser.cpp:1 — 20,193 lines (480× median) |
base/poco/Foundation/src/pcre_jit_compile.c:1 — 11,913 lines (283× median) |
base/poco/Foundation/src/pcre_compile.c:1 — 9,807 lines (233× median) |
base/poco/XML/src/xmlparse.cpp:1 — 9,236 lines (219× median) |
src/Storages/MergeTree/MergeTreeData.cpp:1 — 8,014 lines (190× median) |
Engineering Process & SDLC Maturity
strongTests are retried until they pass
adequateThe suite is configured to retry failing tests (docker/test/stateless_pytest/Dockerfile). A retry turns a flaky test green without saying why it failed, so a green build means the tests passed eventually. Ask how many retries a typical run needs, and which tests need them.
docker/test/stateless_pytest/Dockerfile:34 — test retry |
Product & Engineering Maturity
strongNo finding.
Security & Reliability Posture
adequate6 Dockerfiles run the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
docker/bare/Dockerfile — runs as root |
docker/builder/Dockerfile — runs as root |
docker/client/Dockerfile — runs as root |
docker/packager/binary/Dockerfile — runs as root |
The build runs third-party code it does not pin
adequate5 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/compatibility_test.yml:186 — action pinned by tag |
.github/workflows/manual_trigger_build.yml:497 — action pinned by tag |
20 vendored components with no licence
adequateThird-party code is committed into this repository without any statement of the terms it arrived under. Unknown terms are harder to deal with than inconvenient ones: an awkward licence can be complied with, an absent one cannot. Each of these needs its origin established before the code changes hands.
docs/en/interfaces/third-party/client-libraries.md — 1 tracked files, no licence file |
docs/en/interfaces/third-party/gui.md — 1 tracked files, no licence file |
docs/en/interfaces/third-party/index.md — 1 tracked files, no licence file |
docs/en/interfaces/third-party/integrations.md — 1 tracked files, no licence file |
docs/en/interfaces/third-party/proxy.md — 1 tracked files, no licence file |
docs/ja/interfaces/third-party/client-libraries.md — 1 tracked files, no licence file |
1 advisory against this project in the last 24 months, 1 high or critical
adequateThe newest was published on 2026-03-24. A project that publishes advisories is telling its users about its fixes, and the count and pace say how much security work it carries. None of them affects the surveyed version. The record is incomplete: NVD: 28 records name proton with nothing tying them to this repository (CVE-2016-2166, CVE-2016-4467, CVE-2018-17187, …).
| 2026-03-24: CVE-2026-4746 (critical): Out-of-bounds Write vulnerability in timeplus-io proton (base/poco/Foundation/src modules). This vulnerability is associated with program files inflate.C. Thi |
Observability & Operations
adequateNo structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| C source is not searched: C programs log through printf-style calls unless they take a library, and none of the 10 searched for is referenced |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
2 of 2 deployed images carry no version, or `latest`
adequate2 images in the deployment configuration are named without a version or as `latest`. A redeploy can change the software without a commit, a rollback has nothing to roll back to, and nobody can say from the repository what is running.
docker/compose/docker-compose.yml:5 — image without a version |
docker/compose/docker-compose.yml:34 — image without a version |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on timeplus-io/proton: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.