Borehole · Project · free tier
spotify/luigi
Free reading: not for reliance
f5feb7a · 4,323 commits · 400 files
Read 2026-10-28

spotify/luigi: technical due diligence, read from its repository

What Borehole read in spotify/luigi's code and history at f5feb7a: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.

DimensionRating
Architecture & Codebase — including AI provenancestrong
Engineering Process & SDLC Maturitystrong
Product & Engineering Maturitystrong
Security & Reliability Postureadequate
Observability & Operationsnot assessable
Fit with the Acquirernot assessable

Architecture & Codebase — including AI provenance

strong
01.6

luigi/static/visualiser/lib/URI/1.18.2/URI.js is 2,219 lines, 16× this codebase's median file

adequate

The median source file here is 136 lines. 4 files exceed 1,360 lines, the largest being 2,219. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.

Evidence
luigi/static/visualiser/lib/URI/1.18.2/URI.js:1 — 2,219 lines (16× median)
luigi/parameter.py:1 — 1,855 lines (13× median)
luigi/scheduler.py:1 — 1,674 lines (12× median)
luigi/static/visualiser/js/visualiserApp.js:1 — 1,566 lines (11× median)
01.15

47 errors caught and discarded in product code

adequate

47 places catch an error and do nothing with it, across 18 files (0.7 per thousand lines). Each is a failure the system will not report. They surface later as problems nobody can explain, and they are cheap to fix now.

Evidence
luigi/contrib/hadoop.py:939 — error caught and discarded
luigi/contrib/hdfs/format.py:169 — error caught and discarded
luigi/contrib/hive.py:409 — error caught and discarded

Engineering Process & SDLC Maturity

strong

No finding.

Product & Engineering Maturity

strong
04.5

Effort is shifting from building to rewriting

adequate

Deleted lines per line added rose from 0.61 to 0.89 between the first and second halves of this history. Rework is normal and often healthy, but a rising ratio means an increasing share of the team's time is spent replacing code that already exists rather than building what does not. Whether that is deliberate repayment or churn is a question for the team.

Evidence
first half 0.61, second half 0.89 (split 2019-04-28)

Security & Reliability Posture

adequate
05.21

2 shell commands built from strings

adequate

2 places run a command through a shell (`shell=True`, `os.system`, `exec` with a template) rather than passing arguments. Where any part comes from outside, it is command injection. Ask where each one's input comes from.

Evidence
luigi/contrib/sge.py:287 — command run through a shell
luigi/lock.py:39 — command run through a shell
05.22

5 deserialisers that can run code

adequate

5 places read data with a deserialiser that executes what it reads (pickle). That is safe on data the system wrote itself and remote code execution on anything else. Ask where each one's input comes from.

Evidence
luigi/contrib/lsf_runner.py:43 — code-executing deserialiser
luigi/contrib/mrrunner.py:45 — code-executing deserialiser
luigi/contrib/pyspark_runner.py:102 — code-executing deserialiser
05.26

18 locked dependencies have published vulnerabilities, 11 high or critical in what ships

adequate

18 of 121 locked dependencies match 59 published advisories in OSV, 34 of them rated high or critical. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version.

Evidence
uv.lock — certifi 2025.1.31: GHSA-6q48-6c7w-9gw2 (critical), fixed in 2026.10.18; a development dependency
uv.lock — setuptools 75.8.0: GHSA-5rjg-fvgr-3xxf (high), fixed in 78.1.1
uv.lock — tornado 6.4.2: GHSA-3x9g-8vmp-wqvf (high), fixed in 6.5.6
05.65

1 advisory against this project in the last 24 months, 1 high or critical

adequate

The newest was published on 2024-12-10. A project that publishes advisories is telling its users about its fixes, and the count and pace say how much security work it carries. None of them affects the surveyed version.

Evidence
2024-12-10: GHSA-8qch-vj6m-2694 (high), fixed in 3.6.0: luigi Arbitrary File Write via Archive Extraction (Zip Slip)

Observability & Operations

not assessable

Not rated: only 5 of 16 checks could reach a conclusion here; the rest do not apply to this repository or could not read it.

Fit with the Acquirer

not assessable

Not rated: structurally not assessable from a repository.

Read more, or read your own

The full report on spotify/luigi: every dimension, the questions for the room, and the audit log.

Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.