Read 2026-10-23
siyuan-note/siyuan: technical due diligence, read from its repository
What Borehole read in siyuan-note/siyuan's code and history at bfe3610: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | strong |
| Product & Engineering Maturity | adequate |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
AGENTS.md:97: This repository is a mirror; development happens elsewhere.github/PULL_REQUEST_TEMPLATE.md:31: states a policy on AI-generated contributions
Architecture & Codebase — including AI provenance
strongCommit messages are templated rather than written
adequate48% of commit subjects are exact repeats of another subject, and subject length varies by only 33.8 characters. A log written by someone explaining their reasoning to a future reader does not look like this. The log is therefore weak evidence of intent, whatever the code is like.
| 425× ':rotating_light:' |
| 298× ':memo: Update changelogs' |
| 278× ':sparkles: AI Agent https://github.com/siyuan-note/siyuan/is' |
kernel/model/attribute_view.go is 9,258 lines, 79× this codebase's median file
adequateThe median source file here is 116 lines. 93 files exceed 1,160 lines, the largest being 9,258. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
kernel/model/attribute_view.go:1 — 9,258 lines (79× median) |
kernel/ocr/onnxruntime_c_api.h:1 — 8,290 lines (71× median) |
app/src/types/api/index.d.ts:1 — 8,235 lines (70× median) |
app/src/protyle/wysiwyg/index.ts:1 — 5,663 lines (48× median) |
kernel/model/export.go:1 — 5,263 lines (45× median) |
Engineering Process & SDLC Maturity
strongNo finding.
Product & Engineering Maturity
adequate106 direct dependencies in a single manifest
adequatekernel/go.mod declares 106 direct dependencies. Each one is a maintenance obligation, a supply-chain surface and a potential licence question that transfers with the asset. The count says nothing about whether any given dependency was a good choice; it says how many such choices a buyer inherits.
kernel/go.mod — 106 declared |
app/package.json — 2 declared |
Security & Reliability Posture
adequate1 Dockerfile runs the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
Dockerfile — runs as root |
The build runs third-party code it does not pin
adequate9 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/auto_aur_release_stable.yml:125 — action pinned by tag |
.github/workflows/cd.yml:262 — action pinned by tag |
45 SQL statements built from strings
adequate45 places in product code build SQL by formatting or joining strings rather than passing parameters, and in 37 of them a value, not a table or column name, goes into the string. Where any of those values comes from a request, it is an injection point. Each site needs a look; the fix, parameters, is small.
kernel/model/asset_content.go:161 — SQL built from a string |
kernel/model/search.go:2460 — SQL built from a string |
kernel/model/search.go:2482 — SQL built from a string |
23 locked dependencies have published vulnerabilities, 9 high or critical in what ships
adequate23 of 916 locked dependencies match 99 published advisories in OSV, 73 of them rated high or critical. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version.
app/pnpm-lock.yaml — tar 7.5.16: GHSA-23hp-3jrh-7fpw (critical), fixed in 7.5.19; a development dependency |
kernel/go.mod — github.com/xuri/excelize/v2 v2.11.0: GHSA-2j4c-ffch-9f23 (high), fixed in 2.11.1-0.20260915055537-22f76f9acb94 |
app/pnpm-lock.yaml — @xmldom/xmldom 0.8.13: GHSA-27p8-2357-5qqv (high), fixed in 0.8.15; a development dependency |
310 advisories against this project in the last 24 months, 212 high or critical
adequateThe newest was published on 2026-10-22. A project that publishes advisories is telling its users about its fixes, and the count and pace say how much security work it carries.
| 2026-10-22: GHSA-2x3p-x74g-442x (moderate), fixed in v3.8.9: MCP resources/read triggers nil pointer panic in privateCacheMiddleware (v3.8.7/v3.8.8) |
| 2026-10-13: GHSA-gg3p-r4g8-vxg2 (high), fixed in v3.8.7: SiYuan: \\?\GLOBALROOT alias bypasses IsSensitivePath (v3.8.7 fix incomplete) — API token + TLS keys copied into served assets |
| 2026-10-12: CVE-2026-109309 (moderate): SiYuan v3.7.0 before v3.8.6 contains an absolute path traversal vulnerability in the kernel's private plugin HTTP server, which passes a kernel plugin handler's |
| 2026-10-12: CVE-2026-109310 (high): SiYuan v3.1.12 before v3.8.6 fails to restrict the Sprig template function map in the /api/icon/getDynamicIcon content parameter, allowing resource exhaustion. |
| 2026-10-09: GHSA-hpj5-f7cj-vvwr (moderate), fixed in v3.8.7: The networkServeTLS setting is accepted but never enforced and the kernel port keeps serving cleartext HTTP |
Observability & Operations
adequateNo telemetry or error reporting is wired in anywhere
adequateNone of 4,906 readable files references an instrumentation, metrics or error-reporting library. If this system is in production, nobody learns that it broke from the system itself — they learn it from a customer. That is a reliability finding before it is an observability one.
| searched 4,906 tracked text files for 16 known instrumentation libraries; manifests for metrics, tracing and error-reporting families; locked dependencies for the packages that emit; 0 matched |
No structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| searched 4,906 files for 10 structured logging libraries; 0 matched |
The service logs with print: 345 calls against 15 logger calls
adequate345 `print` or `console.log` calls in the service's code, and 15 calls through a logger. Printed lines carry no level and no context, cannot be switched off, and are hard to find again in production.
app/electron/main.js:864 — print used for logging |
app/electron/main.js:953 — print used for logging |
app/electron/main.js:957 — print used for logging |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on siyuan-note/siyuan: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.