Read 2026-11-03
safing/portmaster: technical due diligence, read from its repository
What Borehole read in safing/portmaster's code and history at bffef13: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | adequate |
| Engineering Process & SDLC Maturity | strong |
| Product & Engineering Maturity | adequate |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
LICENSE: Relicensed: AGPL-3.0 → GPL-3.0 (2024-03-29)
Architecture & Codebase — including AI provenance
adequateservice/firewall/interception/ebpf/programs/bpf/bpf_helper_defs.h is 4,749 lines, 53× this codebase's median file
adequateThe median source file here is 89 lines. 7 files exceed 1,000 lines, the largest being 4,749. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
service/firewall/interception/ebpf/programs/bpf/bpf_helper_defs.h:1 — 4,749 lines (53× median) |
windows_kext/wdk/src/filter_engine/layer.rs:1 — 1,520 lines (17× median) |
desktop/angular/src/app/shared/netquery/netquery.component.ts:1 — 1,372 lines (15× median) |
service/intel/geoip/country_info.go:1 — 1,334 lines (14× median) |
desktop/angular/projects/safing/portmaster-api/src/lib/portapi.service.ts:1 — 1,037 lines (11× median) |
1 base image floats: no version, or `latest`
adequate1 of 2 `FROM` lines in product Dockerfiles name an image without a version, or with `latest`. Each build pulls whatever the registry serves that day, so the image that ships can change without a commit, and last month's build cannot be reproduced. Pin a version, or a digest.
cmds/observation-hub/Dockerfile:32 — base image without a version |
Engineering Process & SDLC Maturity
strongAlmost no process scaffolding exists in the repository
adequateOf five ordinary markers — CI workflows, CODEOWNERS, a pull-request template, pre-commit hooks, contribution guidance — 1 is present: CI workflows. Branch protection itself is a GitHub setting rather than a file, so this is a reading of proxies and not of the rules themselves. What it does establish is that the process is not written down anywhere a new engineer would find it.
| 1 of 5 markers present across 2,116 tracked files |
Product & Engineering Maturity
adequateGo 1.21 is past end of life
adequateThe code is pinned to Go 1.21 (end of life 2024-08-13). None of these receives security fixes any more; the first stopped on 2024-08-13. Moving off an unsupported runtime is rarely a one-line change, so a buyer should ask whether the upgrade is planned and what it touches.
cmds/observation-hub/Dockerfile — Go 1.21, end of life 2024-08-13 |
18% of bug fixes add or change a test
adequateOf 200 fixes in the last 24 months, 36 touched a test. A fix without the test that would have caught the bug can quietly come back, and the suite never learns from what went wrong.
| 36 of 200 |
Security & Reliability Posture
adequate1 Dockerfile runs the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
cmds/observation-hub/Dockerfile — runs as root |
2 outbound calls can wait forever
adequate2 HTTP calls use a client with no timeout (Python `requests` without `timeout=`, or Go's default client). When a dependency slows down, each one holds a worker until the connection gives up, and enough of them take the service down with the dependency.
base/apprise/notify.go:163 — outbound call without a timeout |
spn/access/client.go:32 — outbound call without a timeout |
3 SQL statements built from strings
adequate3 places in product code build SQL by formatting or joining strings rather than passing parameters. 3 of them put a value into the string; in the rest, what the code shows going in is a table or column name, a constant, or something the line does not show. Ask whether any value reaches these strings, rather than a parameter.
service/netquery/database.go:422 — SQL built from a string |
service/netquery/database.go:433 — SQL built from a string |
service/netquery/database.go:448 — SQL built from a string |
42 locked dependencies have published vulnerabilities, 19 high or critical in what ships
adequate42 of 1,213 locked dependencies match 121 published advisories in OSV, 38 of them rated high or critical. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version. This lockfile pins development tools alongside what ships and does not say which is which, so some of these may never reach a user.
windows_kext/release/Cargo.lock — zip 0.6.6: GHSA-m665-v7pm-7grj (critical), fixed in 9.0.5 |
desktop/angular/package-lock.json — @angular/common 16.2.12: GHSA-39pv-4j6c-2g6v (high), fixed in 22.0.1 |
desktop/angular/package-lock.json — @angular/compiler 16.2.12: GHSA-jj27-h5hq-8x99 (high), fixed in 22.0.1 |
The production build publishes source maps
adequateThe build configuration emits source maps for production, so the original source, with its comments and structure, is downloadable by every visitor. Upload them to an error tracker and keep them off the public server instead.
desktop/angular/angular.json:55 — source maps in a production build |
Observability & Operations
adequateNo telemetry or error reporting is wired in anywhere
adequateNone of 1,545 readable files references an instrumentation, metrics or error-reporting library. If this system is in production, nobody learns that it broke from the system itself — they learn it from a customer. That is a reliability finding before it is an observability one.
| searched 1,545 tracked text files for 16 known instrumentation libraries; manifests for metrics, tracing and error-reporting families; locked dependencies for the packages that emit; 0 matched |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on safing/portmaster: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.