Read 2026-11-07
pymumu/smartdns: technical due diligence, read from its repository
What Borehole read in pymumu/smartdns's code and history at dfc9ef4: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | adequate |
| Engineering Process & SDLC Maturity | strong |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
LICENSE: Relicensed: AGPL-3.0 → GPL-3.0 (2020-02-24)
Architecture & Codebase — including AI provenance
adequatesrc/dns.c is 3,298 lines, 24× this codebase's median file
adequateThe median source file here is 137 lines. 7 files exceed 1,370 lines, the largest being 3,298. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
src/dns.c:1 — 3,298 lines (24× median) |
src/http_parse/http2.c:1 — 3,089 lines (22× median) |
src/tlog.c:1 — 2,219 lines (16× median) |
plugin/smartdns-ui/src/db.rs:1 — 1,808 lines (13× median) |
package/luci/files/root/www/luci-static/resources/view/smartdns/smartdns.js:1 — 1,686 lines (12× median) |
1 base image floats: no version, or `latest`
adequate1 of 2 `FROM` lines in product Dockerfiles name an image without a version, or with `latest`. Each build pulls whatever the registry serves that day, so the image that ships can change without a commit, and last month's build cannot be reproduced. Pin a version, or a digest.
Dockerfile:1 — base image without a version |
Engineering Process & SDLC Maturity
strongAlmost no process scaffolding exists in the repository
adequateOf five ordinary markers — CI workflows, CODEOWNERS, a pull-request template, pre-commit hooks, contribution guidance — 1 is present: CI workflows. Branch protection itself is a GitHub setting rather than a file, so this is a reading of proxies and not of the rules themselves. What it does establish is that the process is not written down anywhere a new engineer would find it.
| 1 of 5 markers present across 455 tracked files |
Product & Engineering Maturity
strongNo finding.
Security & Reliability Posture
adequateNone of the standard security guard rails are configured
adequateThere is no disclosure policy, no automated dependency updates, no named code owners and no pre-commit configuration. None of these is load-bearing on its own. Their collective absence says that security posture here is whatever the current team happens to remember to do, which is not a posture that survives the team changing.
| checked 5 kinds of guard rail across 455 tracked files; 0 present |
1 Dockerfile runs the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
Dockerfile — runs as root |
The build runs third-party code it does not pin
adequate7 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day; 2 steps pipe a download straight into a shell. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/docker.yml:22 — action pinned by tag |
.github/workflows/docker.yml:24 — action pinned by tag |
Dockerfile:10 — download piped into a shell |
Relicensed: AGPL-3.0 → GPL-3.0 (2020-02-24)
adequateThe root licence changed 1 time(s). Code taken under earlier terms stays under them; check which terms any fork or customer relied on.
2 advisories against this project in the last 24 months, 1 high or critical
adequateThe newest was published on 2026-01-26. A project that publishes advisories is telling its users about its fixes, and the count and pace say how much security work it carries. Whether 1 of them are fixed in the code you ship could not be told from this history. Answer lives in: the release you run, set against each fixed version. The record is incomplete: NVD: 1 record names smartdns with nothing tying it to this repository (CVE-2026-55159).
| 2026-01-26: CVE-2026-1425 (moderate): A security flaw has been discovered in pymumu SmartDNS up to 47.1. This vulnerability affects the function _dns_decode_rr_head/_dns_decode_SVCB_HTTPS of the fil |
| 2024-10-22: CVE-2024-42643 (high): Integer Overflow in fast_ping.c in SmartDNS Release46 allows remote attackers to cause a Denial of Service via misaligned memory access. |
Observability & Operations
adequateNo telemetry or error reporting is wired in anywhere
adequateNone of 393 readable files references an instrumentation, metrics or error-reporting library. If this system is in production, nobody learns that it broke from the system itself — they learn it from a customer. That is a reliability finding before it is an observability one.
| searched 393 tracked text files for 16 known instrumentation libraries; manifests for metrics, tracing and error-reporting families; locked dependencies for the packages that emit; 0 matched |
No structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| C source is not searched: C programs log through printf-style calls unless they take a library, and none of the 10 searched for is referenced |
One request cannot be followed through the logs
adequateNothing in the service carries a request or correlation id, and there is no tracing. When a customer reports a failure, the log lines that belong to their request cannot be picked out from everyone else's.
| no request id, correlation id or tracing found |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on pymumu/smartdns: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.