Read 2026-11-03
opendatalab/mineru: technical due diligence, read from its repository
What Borehole read in opendatalab/mineru's code and history at 92edabf: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | strong |
| Product & Engineering Maturity | adequate |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
LICENSE.md: Relicensed: AGPL-3.0 → Apache-2.0 with a commercial-licence condition and an attribution term (2026-04-17)
Architecture & Codebase — including AI provenance
strongmineru/model/_internal/pytorchocr/modeling/heads/rec_unimernet_head.py is 2,652 lines, 17× this codebase's median file
adequateThe median source file here is 149 lines. 4 files exceed 1,490 lines, the largest being 2,652. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
mineru/model/_internal/pytorchocr/modeling/heads/rec_unimernet_head.py:1 — 2,652 lines (17× median) |
mineru/parser/api_server.py:1 — 2,249 lines (15× median) |
mineru/model/_internal/pytorchocr/modeling/backbones/rec_pphgnetv2.py:1 — 1,625 lines (10× median) |
mineru/doclib/server.py:1 — 1,504 lines (10× median) |
Engineering Process & SDLC Maturity
strongNo finding.
Product & Engineering Maturity
adequate19% of bug fixes add or change a test
adequateOf 924 fixes in the last 24 months, 177 touched a test. A fix without the test that would have caught the bug can quietly come back, and the suite never learns from what went wrong.
| 177 of 924 |
Security & Reliability Posture
adequate2 Dockerfiles run the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
docker/china/Dockerfile — runs as root |
docker/global/Dockerfile — runs as root |
The build runs third-party code it does not pin
adequate3 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/cla.yml:21 — action pinned by tag |
.github/workflows/cli.yml:55 — action pinned by tag |
10 SQL statements built from strings
adequate10 places in product code build SQL by formatting or joining strings rather than passing parameters. 2 of them put a value into the string; in the rest, what the code shows going in is a table or column name, a constant, or something the line does not show. Ask whether any value reaches these strings, rather than a parameter.
mineru/doclib/services/cleanup_svc.py:125 — SQL built from a string |
mineru/doclib/services/cleanup_svc.py:129 — SQL built from a string |
mineru/doclib/services/config_svc.py:278 — SQL built from a string |
1 deserialiser that can run code
adequate1 places read data with a deserialiser that executes what it reads (`yaml.load` without a safe loader). That is safe on data the system wrote itself and remote code execution on anything else. Ask where each one's input comes from.
mineru/model/mfr/pp_formulanet/predict_formula.py:91 — code-executing deserialiser |
Licence text does not match a standard licence
adequateLICENSE.md exists but its text does not match any standard licence. A bespoke or hand-edited licence is not wrong, but it cannot be cleared by recognising its name: counsel has to read it, and until they do neither side knows precisely what rights transfer with the code.
LICENSE.md:1 — 57 lines, unrecognised |
Relicensed: AGPL-3.0 → Apache-2.0 with a commercial-licence condition and an attribution term (2026-04-17)
adequateThe root licence changed 1 time(s). The latest terms restrict what users, hosts or a buyer may do in ways the earlier ones did not. Code taken under the old terms stays under them, so both matter in diligence.
LICENSE.md — AGPL-3.0 from 2024-03-04 |
LICENSE.md — Apache-2.0 with a commercial-licence condition and an attribution term from 2026-04-17 |
Observability & Operations
adequateNo telemetry or error reporting is wired in anywhere
adequateNone of 964 readable files references an instrumentation, metrics or error-reporting library. If this system is in production, nobody learns that it broke from the system itself — they learn it from a customer. That is a reliability finding before it is an observability one.
| searched 964 tracked text files for 16 known instrumentation libraries; manifests for metrics, tracing and error-reporting families; locked dependencies for the packages that emit; 0 matched |
No structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| searched 964 files for 10 structured logging libraries; 0 matched |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on opendatalab/mineru: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.