Read 2026-10-23
nsqio/nsq: technical due diligence, read from its repository
What Borehole read in nsqio/nsq's code and history at 85cf10c: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | adequate |
| Engineering Process & SDLC Maturity | strong |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
Architecture & Codebase — including AI provenance
adequatensqd/protocol_v2.go is 1,073 lines, 16× this codebase's median file
adequateThe median source file here is 66 lines. 1 file exceed 1,000 lines, the largest being 1,073. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
nsqd/protocol_v2.go:1 — 1,073 lines (16× median) |
1 base image floats: no version, or `latest`
adequate1 of 2 `FROM` lines in product Dockerfiles name an image without a version, or with `latest`. Each build pulls whatever the registry serves that day, so the image that ships can change without a commit, and last month's build cannot be reproduced. Pin a version, or a digest.
Dockerfile:11 — base image without a version |
Engineering Process & SDLC Maturity
strongNo finding.
Product & Engineering Maturity
strongEffort is shifting from building to rewriting
adequateDeleted lines per line added rose from 0.54 to 0.90 between the first and second halves of this history. Rework is normal and often healthy, but a rising ratio means an increasing share of the team's time is spent replacing code that already exists rather than building what does not. Whether that is deliberate repayment or churn is a question for the team.
| first half 0.54, second half 0.90 (split 2019-06-27) |
Security & Reliability Posture
adequateNone of the standard security guard rails are configured
adequateThere is no disclosure policy, no automated dependency updates, no named code owners and no pre-commit configuration. None of these is load-bearing on its own. Their collective absence says that security posture here is whatever the current team happens to remember to do, which is not a posture that survives the team changing.
| checked 5 kinds of guard rail across 230 tracked files; 0 present |
1 Dockerfile runs the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
Dockerfile — runs as root |
The build runs third-party code it does not pin
adequate3 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/test.yml:23 — action pinned by tag |
.github/workflows/test.yml:41 — action pinned by tag |
4 locked dependencies have published vulnerabilities, 2 high or critical in what ships
adequate4 of 21 locked dependencies match 7 published advisories in OSV, 3 of them rated high or critical. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version.
nsqadmin/package-lock.json — moment 2.29.1: GHSA-8hfj-j24r-96c4 (high), fixed in 2.29.2 |
nsqadmin/package-lock.json — underscore 1.13.1: GHSA-qpx9-hpmf-5gmw (high), fixed in 1.13.8; the advisory applies only under a condition it states |
nsqadmin/package-lock.json — bootbox 5.5.2: GHSA-87mg-h5r3-hw88 (moderate) |
Observability & Operations
adequateNo structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| searched 166 files for 10 structured logging libraries; 0 matched |
One request cannot be followed through the logs
adequateNothing in the service carries a request or correlation id, and there is no tracing. When a customer reports a failure, the log lines that belong to their request cannot be picked out from everyone else's.
| no request id, correlation id or tracing found |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on nsqio/nsq: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.