Read 2026-11-03
komari-monitor/komari: technical due diligence, read from its repository
What Borehole read in komari-monitor/komari's code and history at 96cf0f7: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | strong |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
Architecture & Codebase — including AI provenance
strongpkg/metric/store.go is 1,559 lines, 14× this codebase's median file
adequateThe median source file here is 110 lines. 5 files exceed 1,100 lines, the largest being 1,559. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
pkg/metric/store.go:1 — 1,559 lines (14× median) |
pkg/metric/restructure.go:1 — 1,549 lines (14× median) |
pkg/jsruntime/crypto/crypto.go:1 — 1,535 lines (13× median) |
install-komari.sh:1 — 1,466 lines (13× median) |
pkg/jsruntime/stream/stream.js:1 — 1,208 lines (10× median) |
Engineering Process & SDLC Maturity
strongAlmost no process scaffolding exists in the repository
adequateOf five ordinary markers — CI workflows, CODEOWNERS, a pull-request template, pre-commit hooks, contribution guidance — 1 is present: CI workflows. Branch protection itself is a GitHub setting rather than a file, so this is a reading of proxies and not of the rules themselves. What it does establish is that the process is not written down anywhere a new engineer would find it.
| 1 of 5 markers present across 439 tracked files |
Product & Engineering Maturity
strongNo finding.
Security & Reliability Posture
adequateNone of the standard security guard rails are configured
adequateThere is no disclosure policy, no automated dependency updates, no named code owners and no pre-commit configuration. None of these is load-bearing on its own. Their collective absence says that security posture here is whatever the current team happens to remember to do, which is not a posture that survives the team changing.
| checked 5 kinds of guard rail across 439 tracked files; 0 present |
1 Dockerfile runs the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
Dockerfile — runs as root |
The build runs third-party code it does not pin
adequate8 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/development.yml:53 — action pinned by tag |
.github/workflows/docker-publish.yml:85 — action pinned by tag |
4 outbound calls can wait forever
adequate4 HTTP calls use a client with no timeout (Python `requests` without `timeout=`, or Go's default client). When a dependency slows down, each one holds a worker until the connection gives up, and enough of them take the service down with the dependency.
utils/geoip/mmdb.go:114 — outbound call without a timeout |
web/api/admin/theme.go:334 — outbound call without a timeout |
web/oauth/qq/qq.go:37 — outbound call without a timeout |
36 SQL statements built from strings
adequate36 places in product code build SQL by formatting or joining strings rather than passing parameters. In each, what the code shows going in is a table or column name, a constant, or something the line does not show, not a request's value. Ask whether any value reaches these strings, rather than a parameter.
pkg/metric/digest_reclaim.go:41 — SQL built from a string |
pkg/metric/digest_reclaim.go:50 — SQL built from a string |
pkg/metric/digest_reclaim.go:95 — SQL built from a string |
2 locked dependencies have published vulnerabilities
adequate2 of 54 locked dependencies match 2 published advisories in OSV. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version.
7 advisories against this project in the last 24 months, 3 high or critical
adequateThe newest was published on 2026-10-30. A project that publishes advisories is telling its users about its fixes, and the count and pace say how much security work it carries. Whether 1 of them are fixed in the code you ship could not be told from this history: its version is only known to be at least 1.6.1. Answer lives in: the release you run, set against each fixed version.
| 2026-10-30: GHSA-3hqg-6m62-cgxf (low): Global admin API key uses a non-constant-time comparison with no rate limiting |
| 2026-10-30: GHSA-74qc-gfcj-9273 (moderate), fixed in 1.2.5-fix1: Komari v1.2.0 管理端主题删除接口存在路径穿越漏洞 |
| 2026-10-30: GHSA-h8jh-mv4w-3gm5 (moderate), fixed in 1.6.0: 前端 `new Function` 注入 |
| 2026-10-30: GHSA-j2jg-mq93-mqg4 (low), fixed in 1.5.0: SSRF Vulnerability Caused by DNS Rebinding in Theme Download (TOCTOU) |
| 2026-06-20: GHSA-hxjg-93wc-h8p8 (high), fixed in 0.0.0-20260609084633-98122fa4d110: Komari: Management Interface CSRF |
Observability & Operations
adequateNo telemetry or error reporting is wired in anywhere
adequateNone of 436 readable files references an instrumentation, metrics or error-reporting library. If this system is in production, nobody learns that it broke from the system itself — they learn it from a customer. That is a reliability finding before it is an observability one.
| searched 436 tracked text files for 16 known instrumentation libraries; manifests for metrics, tracing and error-reporting families; locked dependencies for the packages that emit; 0 matched |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on komari-monitor/komari: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.