Read 2026-11-03
infiniflow/infinity: technical due diligence, read from its repository
What Borehole read in infiniflow/infinity's code and history at 1c3abda: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | adequate |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
.gitmodules:1: 1 submodule(s) this survey does not read: resource
Architecture & Codebase — including AI provenance
strongsrc/network/infinity_thrift/infinity_types.cpp is 19,946 lines, 216× this codebase's median file
adequateThe median source file here is 92 lines. 66 files exceed 1,000 lines, the largest being 19,946. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
src/network/infinity_thrift/infinity_types.cpp:1 — 19,946 lines (216× median) |
src/network/infinity_thrift/InfinityService.cpp:1 — 19,002 lines (206× median) |
python/infinity_sdk/infinity/remote_thrift/infinity_thrift_rpc/ttypes.py:1 — 12,383 lines (134× median) |
src/parser/parser.cpp:1 — 10,445 lines (113× median) |
python/infinity_sdk/infinity/remote_thrift/infinity_thrift_rpc/InfinityService.py:1 — 10,302 lines (111× median) |
Engineering Process & SDLC Maturity
adequateCI runs tests that cannot fail the build
adequate4 test commands in CI end in `|| true` or an equivalent, so the pipeline passes whatever the tests say. A green build then means the tests ran, not that they passed.
.github/workflows/tests.yml:608 — a test command that cannot fail |
.github/workflows/tests.yml:1278 — a test command that cannot fail |
.github/workflows/tests.yml:1887 — a test command that cannot fail |
10% of recent commits change more than 2,000 lines
adequate85 of 848 commits in the last 24 months changed over 2,000 lines of code, not counting reformatting, renames, vendored or generated code. A change that size is rarely reviewed line by line. Ask how they were reviewed, and what made them that large.
| 85 commits over 2,000 lines |
Product & Engineering Maturity
strongEffort is shifting from building to rewriting
adequateDeleted lines per line added rose from 0.64 to 0.80 between the first and second halves of this history. Rework is normal and often healthy, but a rising ratio means an increasing share of the team's time is spent replacing code that already exists rather than building what does not. Whether that is deliberate repayment or churn is a question for the team.
| first half 0.64, second half 0.80 (split 2024-09-09) |
Security & Reliability Posture
adequateNone of the standard security guard rails are configured
adequateThere is no disclosure policy, no automated dependency updates, no named code owners and no pre-commit configuration. None of these is load-bearing on its own. Their collective absence says that security posture here is whatever the current team happens to remember to do, which is not a posture that survives the team changing.
| checked 5 kinds of guard rail across 4,058 tracked files; 0 present |
The build runs third-party code it does not pin
adequate7 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/release.yml:177 — action pinned by tag |
.github/workflows/release.yml:183 — action pinned by tag |
4 outbound calls can wait forever
adequate4 HTTP calls use a client with no timeout (Python `requests` without `timeout=`, or Go's default client). When a dependency slows down, each one holds a worker until the connection gives up, and enough of them take the service down with the dependency.
python/infinity_sdk/infinity/infinity_http.py:161 — outbound call without a timeout |
python/infinity_sdk/infinity/infinity_http.py:163 — outbound call without a timeout |
python/infinity_sdk/infinity/infinity_http.py:165 — outbound call without a timeout |
44 locked dependencies have published vulnerabilities, 11 high or critical in what ships
adequate44 of 777 locked dependencies match 139 published advisories in OSV, 82 of them rated high or critical. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version.
uv.lock — certifi 2025.11.12: GHSA-6q48-6c7w-9gw2 (critical), fixed in 2026.10.18 |
uv.lock — anyio 4.12.0: GHSA-82r6-8w77-94w6 (critical), fixed in 4.14.2; an optional extra |
gui/pnpm-lock.yaml — @auth/core 0.41.0: GHSA-7rqj-j65f-68wh (critical), fixed in 0.41.3; in a separate application's lockfile |
3 vendored components with no licence
adequateThird-party code is committed into this repository without any statement of the terms it arrived under. Unknown terms are harder to deal with than inconvenient ones: an awkward licence can be complied with, an absent one cannot. Each of these needs its origin established before the code changes hands.
third_party/CMakeLists.txt — 1 tracked files, no licence file |
third_party/darts — 1 tracked files, no licence file |
third_party/versions — 1 tracked files, no licence file |
Observability & Operations
adequateNo telemetry or error reporting is wired in anywhere
adequateNone of 2,715 readable files references an instrumentation, metrics or error-reporting library. If this system is in production, nobody learns that it broke from the system itself — they learn it from a customer. That is a reliability finding before it is an observability one.
| searched 2,715 tracked text files for 16 known instrumentation libraries; manifests for metrics, tracing and error-reporting families; locked dependencies for the packages that emit; 0 matched |
One request cannot be followed through the logs
adequateNothing in the service carries a request or correlation id, and there is no tracing. When a customer reports a failure, the log lines that belong to their request cannot be picked out from everyone else's.
| no request id, correlation id or tracing found |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on infiniflow/infinity: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.