Read 2026-11-03
hkuds/vibe-trading: technical due diligence, read from its repository
What Borehole read in hkuds/vibe-trading's code and history at 2ac2087: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | strong |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
CONTRIBUTING.md:93: states a policy on AI-generated contributionsCONTRIBUTING.md:150: names Linux Foundation
Architecture & Codebase — including AI provenance
strongagent/cli/_legacy.py is 6,903 lines, 58× this codebase's median file
adequateThe median source file here is 119 lines. 32 files exceed 1,190 lines, the largest being 6,903. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
agent/cli/_legacy.py:1 — 6,903 lines (58× median) |
agent/mcp_server.py:1 — 3,471 lines (29× median) |
agent/src/agent/grounding/policies.py:1 — 2,655 lines (22× median) |
agent/backtest/engines/base.py:1 — 2,504 lines (21× median) |
agent/src/channels/feishu.py:1 — 2,493 lines (20× median) |
Engineering Process & SDLC Maturity
strongNo finding.
Product & Engineering Maturity
strongNo finding.
Security & Reliability Posture
adequate4 credential-shaped strings in the tree sit in tests, examples, documentation or local development settings
adequateStrings shaped like credentials appear only where fakes are usual: test fixtures, examples, documentation, placeholders and local stacks. They are almost always fakes. Ask someone to confirm that none of them works anywhere, because a real key in a development file is still a real key. 2 other matchs set aside: expired tokens, licence tokens a vendor verifies with a public key, or placeholder text where a key would go. None grants access to anything.
| AWS access key, where fakes are usual |
| 3 cited: Slack token, where fakes are usual |
4 credential-shaped strings added in the history sit in tests, examples, documentation or local development settings
adequateStrings shaped like credentials appear only where fakes are usual: test fixtures, examples, documentation, placeholders and local stacks. They are almost always fakes. Ask someone to confirm that none of them works anywhere, because a real key in a development file is still a real key. 1 other match set aside: expired tokens, licence tokens a vendor verifies with a public key, or placeholder text where a key would go. None grants access to anything.
| 3 cited: Slack token, where fakes are usual |
| AWS access key, where fakes are usual |
12 SQL statements built from strings
adequate12 places in product code build SQL by formatting or joining strings rather than passing parameters. 3 of them put a value into the string; in the rest, what the code shows going in is a table or column name, a constant, or something the line does not show. Ask whether any value reaches these strings, rather than a parameter.
agent/backtest/loaders/base.py:767 — SQL built from a string |
agent/src/br_data/__main__.py:24 — SQL built from a string |
agent/src/strategy_store/sqlite_store.py:663 — SQL built from a string |
1 locked dependency has published vulnerabilities
adequate1 of 152 locked dependencies match 1 published advisories in OSV. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version.
frontend/package-lock.json — katex 0.16.47: GHSA-238p-pmpm-9mq7 (low), fixed in 0.18.2 |
4 advisories against this project in the last 24 months, 4 high or critical
adequateThe newest was published on 2026-07-29. A project that publishes advisories is telling its users about its fixes, and the count and pace say how much security work it carries. None of them affects the surveyed version.
| 2026-07-29: GHSA-5rmq-chc7-m22f (high), fixed in 0.1.7: Vibe-Trading file-read tools expose arbitrary server-readable files |
| 2026-07-29: GHSA-jqmf-mx4f-hfr6 (critical), fixed in 0.1.7: Vibe-Trading LLM-callable tools permit command execution, code injection, and SSRF |
| 2026-07-29: GHSA-v2f8-6655-7grj (critical), fixed in 0.1.7: Vibe-Trading FastAPI endpoints permit unauthenticated access, file upload, and an RCE chain |
| 2026-06-30: CVE-2026-58170 (high): Vibe-Trading before 0.1.10 builds the proposal file path by joining a caller-supplied proposal identifier onto the broker proposals directory without sanitizati |
Observability & Operations
adequateNo structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| searched 2,822 files for 10 structured logging libraries; 0 matched |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on hkuds/vibe-trading: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.