Read 2026-10-04
git.sr.ht/~rjarry/aerc: technical due diligence, read from its repository
What Borehole read in git.sr.ht/~rjarry/aerc's code and history at 0d169b7: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | strong |
| Product & Engineering Maturity | adequate |
| Security & Reliability Posture | strong |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
Architecture & Codebase — including AI provenance
strongapp/compose.go is 2,027 lines, 22× this codebase's median file
adequateThe median source file here is 89 lines. 7 files exceed 1,000 lines, the largest being 2,027. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
app/compose.go:1 — 2,027 lines (22× median) |
lib/msgstore.go:1 — 1,109 lines (12× median) |
worker/notmuch/worker.go:1 — 1,100 lines (12× median) |
app/aerc.go:1 — 1,094 lines (12× median) |
filters/colorize.c:1 — 1,029 lines (11× median) |
Engineering Process & SDLC Maturity
strongNo finding.
Product & Engineering Maturity
adequate9% of bug fixes add or change a test
adequateOf 91 fixes in the last 24 months, 8 touched a test. A fix without the test that would have caught the bug can quietly come back, and the suite never learns from what went wrong.
| 8 of 91 |
Security & Reliability Posture
strong2 outbound calls can wait forever
adequate2 HTTP calls use a client with no timeout (Python `requests` without `timeout=`, or Go's default client). When a dependency slows down, each one holds a worker until the connection gives up, and enough of them take the service down with the dependency.
commands/account/import-mbox.go:135 — outbound call without a timeout |
commands/msg/unsubscribe.go:225 — outbound call without a timeout |
16 shell commands built from strings
adequate16 places run a command through a shell (`shell=True`, `os.system`, `exec` with a template) rather than passing arguments. Where any part comes from outside, it is command injection. Ask where each one's input comes from.
app/compose.go:1885 — command run through a shell |
app/msgviewer.go:500 — command run through a shell |
app/msgviewer.go:517 — command run through a shell |
Observability & Operations
adequateNo telemetry or error reporting is wired in anywhere
adequateNone of 446 readable files references an instrumentation, metrics or error-reporting library. If this system is in production, nobody learns that it broke from the system itself — they learn it from a customer. That is a reliability finding before it is an observability one.
| searched 446 tracked text files for 16 known instrumentation libraries; manifests for metrics, tracing and error-reporting families; locked dependencies for the packages that emit; 0 matched |
No structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| searched 446 files for 10 structured logging libraries; 0 matched |
One request cannot be followed through the logs
adequateNothing in the service carries a request or correlation id, and there is no tracing. When a customer reports a failure, the log lines that belong to their request cannot be picked out from everyone else's.
| no request id, correlation id or tracing found |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on git.sr.ht/~rjarry/aerc: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.