Read 2026-11-03
frappe/builder: technical due diligence, read from its repository
What Borehole read in frappe/builder's code and history at fc9eb67: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | strong |
| Product & Engineering Maturity | adequate |
| Security & Reliability Posture | strong |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
- Releases are cut from another branch than the one surveyed
LICENSE: Relicensed: AGPL-3.0 → MIT (2026-07-16).gitmodules:1: 1 submodule(s) this survey does not read: frappe-ui
Architecture & Codebase — including AI provenance
strongbuilder/builder/doctype/builder_page/builder_page.py is 2,028 lines, 25× this codebase's median file
adequateThe median source file here is 79 lines. 7 files exceed 1,000 lines, the largest being 2,028. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
builder/builder/doctype/builder_page/builder_page.py:1 — 2,028 lines (25× median) |
builder/ai/agent/loop.py:1 — 1,510 lines (19× median) |
frontend/src/components/Modals/TokenManager.vue:1 — 1,165 lines (14× median) |
frontend/src/block.ts:1 — 1,160 lines (14× median) |
frontend/src/utils/helpers.ts:1 — 1,079 lines (13× median) |
Engineering Process & SDLC Maturity
strongNo finding.
Product & Engineering Maturity
adequate9% of bug fixes add or change a test
adequateOf 1826 fixes in the last 24 months, 165 touched a test. A fix without the test that would have caught the bug can quietly come back, and the suite never learns from what went wrong.
| 165 of 1826 |
Releases are cut from another branch than the one surveyed
adequateThe newest release, v1.36.6, is not on the branch this survey read; the newest release on it is v1.18.0. The shipped product may differ from what this report describes. Survey the release branch too.
| tag v1.36.6 |
Security & Reliability Posture
strongThe build runs third-party code it does not pin
adequate7 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/assets.yml:10 — action pinned by tag |
.github/workflows/docker-image.yml:26 — action pinned by tag |
4 SQL statements built from strings
adequate4 places in product code build SQL by formatting or joining strings rather than passing parameters. In each, what the code shows going in is a table or column name, a constant, or something the line does not show, not a request's value. Ask whether any value reaches these strings, rather than a parameter.
builder/builder_analytics.py:167 — SQL built from a string |
builder/builder_analytics.py:183 — SQL built from a string |
builder/builder_analytics.py:427 — SQL built from a string |
27 locked dependencies have published vulnerabilities, 22 high or critical
adequate27 of 1,287 locked dependencies match 54 published advisories in OSV, 22 of them rated high or critical. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version. This lockfile pins development tools alongside what ships and does not say which is which, so some of these may never reach a user.
29 places insert HTML from a variable without sanitising it
adequate29 places set HTML from a value that is neither a literal nor passed through a sanitiser. Where the value can come from a user, that is stored cross-site scripting, and it is the first thing a buyer's security review looks for in a frontend.
builder/public/js/editor_demo.js:19 — HTML from a variable |
frontend/src/block.ts:136 — HTML from a variable |
frontend/src/block.ts:191 — HTML from a variable |
Relicensed: AGPL-3.0 → MIT (2026-07-16)
adequateThe root licence changed 1 time(s). Code taken under earlier terms stays under them; check which terms any fork or customer relied on.
3 advisories against this project in the last 24 months
adequateThe newest was published on 2026-10-26. A project that publishes advisories is telling its users about its fixes, and the count and pace say how much security work it carries. None of them affects the surveyed commit. GHSA-5qcg-q3jf-fjcg (moderate), GHSA-hvrf-fhv3-3v7p (moderate) are fixed in the surveyed commit; which release carries them cannot be told from this history, which does not place the release users run. Answer lives in: the version you run.
| 2026-10-26: GHSA-58mj-c563-p78w (moderate), fixed in 1.36.0: Any authenticated user can spend the site's AI provider credits through improve_prompt |
| 2026-10-26: GHSA-5qcg-q3jf-fjcg (moderate), fixed in 1.36.1: Any authenticated user can make the server fetch internal URLs and write files through convert_to_webp |
| 2026-10-26: GHSA-hvrf-fhv3-3v7p (moderate), fixed in 1.36.1: SSRF guard bypass through redirects and DNS rebinding in remote asset fetches |
Observability & Operations
adequateNo structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| searched 682 files for 10 structured logging libraries; 0 matched |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
1 of 3 deployed images carry no version, or `latest`
adequate1 images in the deployment configuration are named without a version or as `latest`. A redeploy can change the software without a commit, a rollback has nothing to roll back to, and nobody can say from the repository what is running.
docker/docker-compose.yml:19 — image without a version |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on frappe/builder: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.