Read 2026-11-03
dtyq/magic: technical due diligence, read from its repository
What Borehole read in dtyq/magic's code and history at 0f1432c: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | adequate |
| Engineering Process & SDLC Maturity | adequate |
| Product & Engineering Maturity | adequate |
| Security & Reliability Posture | adequate |
| Observability & Operations | strong |
| Fit with the Acquirer | not assessable |
Architecture & Codebase — including AI provenance
adequatefrontend/magic-web/src/pages/superMagic/components/Detail/contents/HTML/templates/dashboard/dashboard.js is 12,619 lines, 170× this codebase's median file
adequateThe median source file here is 74 lines. 204 files exceed 1,000 lines, the largest being 12,619. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
frontend/magic-web/src/pages/superMagic/components/Detail/contents/HTML/templates/dashboard/dashboard.js:1 — 12,619 lines (170× median) |
backend/super-magic/static/http_client/js/client.js:1 — 12,420 lines (167× median) |
backend/magic-service/app/Domain/SuperMagic/File/Service/TaskFileDomainService.php:1 — 5,255 lines (71× median) |
backend/magic-service/app/Application/SuperMagic/Common/Share/Service/ResourceShareAppService.php:1 — 4,872 lines (65× median) |
backend/super-magic/app/magic/agent.py:1 — 4,414 lines (59× median) |
1 base image floats: no version, or `latest`
adequate1 of 17 `FROM` lines in product Dockerfiles name an image without a version, or with `latest`. Each build pulls whatever the registry serves that day, so the image that ships can change without a commit, and last month's build cannot be reproduced. Pin a version, or a digest.
backend/magic-service/go-engine/Dockerfile:17 — base image without a version |
Engineering Process & SDLC Maturity
adequateNothing in the history is tagged as a release
adequateAcross 13.7 years of history there is not one tag. There may still be a deployment process, but this repository holds no record of what shipped when — which is the record a buyer needs to reconstruct an incident or a regression after the fact.
| 0 tags across 10,326 commits and 4988 days |
Product & Engineering Maturity
adequate271 direct dependencies in a single manifest
adequatefrontend/magic-web/package.json declares 271 direct dependencies. Each one is a maintenance obligation, a supply-chain surface and a potential licence question that transfers with the asset. The count says nothing about whether any given dependency was a good choice; it says how many such choices a buyer inherits.
frontend/magic-web/package.json — 271 declared |
backend/magic-service/go-engine/go.mod — 34 declared |
frontend/eslint-config/package.json — 34 declared |
frontend/magic-flow/package.json — 29 declared |
Security & Reliability Posture
adequateNone of the standard security guard rails are configured
adequateThere is no disclosure policy, no automated dependency updates, no named code owners and no pre-commit configuration. None of these is load-bearing on its own. Their collective absence says that security posture here is whatever the current team happens to remember to do, which is not a posture that survives the team changing.
| checked 5 kinds of guard rail across 26,408 tracked files; 0 present |
6 Dockerfiles run the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
backend/magic-gateway/Dockerfile — runs as root |
backend/magic-service/Dockerfile — runs as root |
backend/magic-service/go-engine/Dockerfile — runs as root |
backend/sandbox-components/Dockerfile — runs as root |
The build runs third-party code it does not pin
adequate7 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day; 1 step pipes a download straight into a shell. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/image-build.yml:42 — action pinned by tag |
.github/workflows/image-build.yml:45 — action pinned by tag |
backend/super-magic/Dockerfile:135 — download piped into a shell |
4 outbound calls can wait forever
adequate4 HTTP calls use a client with no timeout (Python `requests` without `timeout=`, or Go's default client). When a dependency slows down, each one holds a worker until the connection gives up, and enough of them take the service down with the dependency.
backend/sandbox-components/pkg/agent-deployer/client/webhook_client.go:29 — outbound call without a timeout |
backend/super-magic/app/infrastructure/observability/requests_integration.py:180 — outbound call without a timeout |
backend/super-magic/app/infrastructure/storage/base.py:374 — outbound call without a timeout |
4 shell commands built from strings
adequate4 places run a command through a shell (`shell=True`, `os.system`, `exec` with a template) rather than passing arguments. Where any part comes from outside, it is command injection. Ask where each one's input comes from.
backend/super-magic/agentlang/agentlang/agent/processors/shell.py:77 — command run through a shell |
backend/super-magic/deploy/setup_font.py:269 — command run through a shell |
backend/super-magic/deploy/setup_font.py:276 — command run through a shell |
15 deserialisers that can run code
adequate15 places read data with a deserialiser that executes what it reads (PHP `unserialize`, `yaml.load` without a safe loader). That is safe on data the system wrote itself and remote code execution on anything else. Ask where each one's input comes from.
backend/async-event/src/Kernel/Executor/AsyncListenerExecutor.php:53 — code-executing deserialiser |
backend/async-event/src/Kernel/Executor/AsyncListenerExecutor.php:98 — code-executing deserialiser |
backend/flow-expr-engine/src/Structure/Form/Form.php:268 — code-executing deserialiser |
128 locked dependencies have published vulnerabilities, 31 high or critical in what ships
adequate128 of 5,315 locked dependencies match 215 published advisories in OSV, 105 of them rated high or critical. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version. This lockfile pins development tools alongside what ships and does not say which is which, so some of these may never reach a user.
backend/magic-service/go-engine/go.mod — github.com/rabbitmq/amqp091-go v1.10.0: GHSA-33mj-cw25-m34h (critical), fixed in 1.13.0 |
backend/sandbox-components/go.mod — golang.org/x/crypto v0.32.0: GHSA-5cgq-3rg8-m6cv (critical), fixed in 0.52.0 |
backend/magic-service/go-engine/go.mod — golang.org/x/crypto v0.50.0: GHSA-5cgq-3rg8-m6cv (critical), fixed in 0.52.0 |
69 places insert HTML from a variable without sanitising it
adequate69 places set HTML from a value that is neither a literal nor passed through a sanitiser. Where the value can come from a user, that is stored cross-site scripting, and it is the first thing a buyer's security review looks for in a frontend.
backend/super-magic/static/http_client/js/client.js:4638 — HTML from a variable |
backend/super-magic/static/http_client/js/client.js:8005 — HTML from a variable |
backend/super-magic/static/http_client/js/client.js:8143 — HTML from a variable |
The production build publishes source maps
adequateThe build configuration emits source maps for production, so the original source, with its comments and structure, is downloadable by every visitor. Upload them to an error tracker and keep them off the public server instead.
frontend/magic-web/packages/html2image/vite.config.ts:21 — source maps in a production build |
frontend/magic-web/packages/html2pptx/vite.config.ts:36 — source maps in a production build |
frontend/magic-web/packages/pdf-export/vite.config.ts:21 — source maps in a production build |
3 vendored components with no licence
adequateThird-party code is committed into this repository without any statement of the terms it arrived under. Unknown terms are harder to deal with than inconvenient ones: an awkward licence can be complied with, an absent one cannot. Each of these needs its origin established before the code changes hands.
cli/deps/common_tool_linux.go — 1 tracked files, no licence file |
cli/deps/common_tool_notlinux.go — 1 tracked files, no licence file |
cli/deps/dep.go — 1 tracked files, no licence file |
Licence text does not match a standard licence
adequateLICENSE exists but its text does not match any standard licence. A bespoke or hand-edited licence is not wrong, but it cannot be cleared by recognising its name: counsel has to read it, and until they do neither side knows precisely what rights transfer with the code.
LICENSE:1 — 35 lines, unrecognised |
Observability & Operations
strongNo error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on dtyq/magic: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.