Read 2026-10-23
dromara/maxkey: technical due diligence, read from its repository
What Borehole read in dromara/maxkey's code and history at e147ade: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | adequate |
| Engineering Process & SDLC Maturity | adequate |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
.gitmodules:1: 1 submodule(s) this survey does not read: summer-ospp/2023/shenyu
Architecture & Codebase — including AI provenance
adequateCommit messages are templated rather than written
adequate39% of commit subjects are exact repeats of another subject, and subject length varies by only 18.5 characters. A log written by someone explaining their reasoning to a future reader does not look like this. The log is therefore weak evidence of intent, whatever the code is like.
| 112× 'Update README.md' |
| 49× 'Update ReleaseNotes.txt' |
| 40× 'readme' |
maxkey-entity/src/main/java/org/dromara/maxkey/entity/idm/UserInfo.java is 1,641 lines, 25× this codebase's median file
adequateThe median source file here is 65 lines. 12 files exceed 1,000 lines, the largest being 1,641. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
maxkey-entity/src/main/java/org/dromara/maxkey/entity/idm/UserInfo.java:1 — 1,641 lines (25× median) |
sql/olderVersions/v4.0.5.ga/maxkey.sql:1 — 1,254 lines (19× median) |
sql/olderVersions/v4.0.0.ga/maxkey.sql:1 — 1,244 lines (19× median) |
sql/olderVersions/v4.1.4/maxkey.sql:1 — 1,223 lines (18× median) |
sql/olderVersions/v4.1.6/maxkey.sql:1 — 1,223 lines (18× median) |
5 base images float: no version, or `latest`
adequate5 of 8 `FROM` lines in product Dockerfiles name an image without a version, or with `latest`. Each build pulls whatever the registry serves that day, so the image that ships can change without a commit, and last month's build cannot be reproduced. Pin a version, or a digest.
deployment/docker/docker-nginx/Dockerfile:3 — base image without a version |
maxkey-web-frontend/maxkey-web-mgt-ng/Dockerfile:3 — base image without a version |
maxkey-web-frontend/maxkey-web-mgt-ng/Dockerfile:9 — base image without a version |
Engineering Process & SDLC Maturity
adequateTests cover a thin slice of the codebase
adequate155 test files against 1,620 source files (9.6%). This does not measure whether the tests are good, only whether enough of them exist for the codebase to be changed safely by someone who did not write it — which is exactly the situation after an acquisition.
| 155 test files / 1,620 source files |
32% of commit subjects say nothing about the change
adequate864 of 2,715 subjects are either under twelve characters or one of the standard placeholders — wip, fix, update. The history is therefore not usable for reconstructing why a decision was taken, which is the main thing an inheriting engineer needs it for. It says nothing about code quality and a great deal about how much context transfers with the asset.
| 864/2,715 low-content subjects (31.8%) |
| 'rm' |
| 'rm' |
| 'rm' |
| 'rm' |
Product & Engineering Maturity
strongNo finding.
Security & Reliability Posture
adequate129 dependencies float, and no lockfile is committed
adequateDependency versions are declared as ranges and no lockfile is committed, so a build today does not necessarily produce what a build last month produced. That matters twice over in a transaction: the thing being bought cannot be reproduced exactly, and a compromised upstream release arrives without anyone choosing to take it.
6 Dockerfiles run the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
deployment/docker/docker-nginx/Dockerfile — runs as root |
maxkey-web-frontend/maxkey-web-mgt-ng/Dockerfile — runs as root |
maxkey-web-frontend/maxkey-web-ng/Dockerfile — runs as root |
maxkey-webs/maxkey-web-maxkey/Dockerfile — runs as root |
The build runs third-party code it does not pin
adequate5 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
maxkey-web-frontend/maxkey-web-mgt-ng/.github/workflows/ci.yml:27 — action pinned by tag |
maxkey-web-frontend/maxkey-web-mgt-ng/.github/workflows/ci.yml:109 — action pinned by tag |
9 SQL statements built from strings
adequate9 places in product code build SQL by formatting or joining strings rather than passing parameters, and in 8 of them a value, not a table or column name, goes into the string. Where any of those values comes from a request, it is an injection point. Each site needs a look; the fix, parameters, is small.
maxkey-authentications/maxkey-authentication-core/src/main/java/org/dromara/maxkey/authn/session/impl/SessionManagerImpl.java:55 — SQL built from a string |
maxkey-persistence/src/main/java/org/dromara/maxkey/persistence/mapper/InstitutionsMapper.java:26 — SQL built from a string |
maxkey-persistence/src/main/java/org/dromara/maxkey/persistence/mapper/UserInfoMapper.java:41 — SQL built from a string |
1 deserialiser that can run code
adequate1 places read data with a deserialiser that executes what it reads (Java object streams). That is safe on data the system wrote itself and remote code execution on anything else. Ask where each one's input comes from.
maxkey-commons/maxkey-common/src/main/java/org/dromara/maxkey/util/SerializationUtils.java:51 — code-executing deserialiser |
The production build publishes source maps
adequateThe build configuration emits source maps for production, so the original source, with its comments and structure, is downloadable by every visitor. Upload them to an error tracker and keep them off the public server instead.
maxkey-web-frontend/maxkey-web-mgt-ng/angular.json:85 — source maps in a production build |
maxkey-web-frontend/maxkey-web-ng/angular.json:84 — source maps in a production build |
11 advisories against this project in the last 24 months, 10 high or critical
adequateThe newest was published on 2026-10-19. A project that publishes advisories is telling its users about its fixes, and the count and pace say how much security work it carries. Whether 1 of them are fixed in the code you ship could not be told from this history: its version is only known to be at least 4.2.0. Answer lives in: the release you run, set against each fixed version. The record is incomplete: NVD: 1 record names MaxKey with nothing tying it to this repository (CVE-2026-7699).
| 2026-10-19: GHSA-rc3j-vmjm-98rm (high), fixed in 4.2.0: TOTP shared secret generated with java.util.Random instead of SecureRandom, enabling 2FA bypass via PRNG state recovery |
| 2026-08-11: CVE-2026-69102 (critical): MaxKey contains an unauthorized access vulnerability due to a hard-coded JWT signing secret in application-maxkey.properties that allows unauthenticated attacke |
| 2026-07-30: CVE-2026-67345 (high): MaxKey through 4.1.12, fixed in commit ddbb72f, contains an insufficient redirect URI validation vulnerability in DefaultRedirectResolver.hostMatches() that all |
| 2026-07-20: GHSA-frgp-wv26-8g4m (critical): MaxKey OpenAPI Credentials Can Reset Any User Password |
| 2026-07-20: GHSA-h822-h3qf-x45g (high): Tenant Administrator Can Modify Another Tenant User's Account State by Username |
Observability & Operations
adequateNo structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| searched 2,014 files for 10 structured logging libraries; 0 matched |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on dromara/maxkey: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.