Read 2026-10-23
didi/dokit: technical due diligence, read from its repository
What Borehole read in didi/dokit's code and history at 626827c: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | adequate |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | not assessable |
| Fit with the Acquirer | not assessable |
Architecture & Codebase — including AI provenance
strongCommit messages are templated rather than written
adequate37% of commit subjects are exact repeats of another subject, and subject length varies by only 20.0 characters. A log written by someone explaining their reasoning to a future reader does not look like this. The log is therefore weak evidence of intent, whatever the code is like.
| 49× 'Update README.md' |
| 36× 'readme' |
| 23× 'fix' |
iOS/DoraemonKit/Src/Core/Plugin/UI/Hierarchy/Function/Category/NSObject+DoraemonHierarchy.m is 2,528 lines, 48× this codebase's median file
adequateThe median source file here is 52 lines. 17 files exceed 1,000 lines, the largest being 2,528. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
iOS/DoraemonKit/Src/Core/Plugin/UI/Hierarchy/Function/Category/NSObject+DoraemonHierarchy.m:1 — 2,528 lines (48× median) |
Android/dokit-util/src/main/java/com/didichuxing/doraemonkit/util/ImageUtils.java:1 — 2,375 lines (45× median) |
Android/dokit-util/src/main/java/com/didichuxing/doraemonkit/util/ActivityUtils.java:1 — 2,145 lines (41× median) |
Android/dokit-util/src/main/java/com/didichuxing/doraemonkit/util/ArrayUtils.java:1 — 2,145 lines (41× median) |
Android/dokit-util/src/main/java/com/didichuxing/doraemonkit/util/FragmentUtils.java:1 — 1,882 lines (36× median) |
A move from Java to Kotlin began 64 months ago and is 38% done
adequate430 product files are in the new language and 715 are still in the old one, 64 months after the first new file appeared. The new language's share of the lines rose from 5% to 25%, and moved 0 percentage points in the last year. Two languages for one job doubles what an engineer has to know, and the unmoved half is usually what nobody wants to touch. Ask whether finishing it is planned, and what it costs.
| 715 old, 430 new |
Engineering Process & SDLC Maturity
adequateTests cover a thin slice of the codebase
adequate157 test files against 2,274 source files (6.9%). This does not measure whether the tests are good, only whether enough of them exist for the codebase to be changed safely by someone who did not write it — which is exactly the situation after an acquisition.
| 157 test files / 2,274 source files |
Almost no process scaffolding exists in the repository
adequateOf five ordinary markers — CI workflows, CODEOWNERS, a pull-request template, pre-commit hooks, contribution guidance — 1 is present: contribution guidance. Branch protection itself is a GitHub setting rather than a file, so this is a reading of proxies and not of the rules themselves. What it does establish is that the process is not written down anywhere a new engineer would find it.
| 1 of 5 markers present across 3,661 tracked files |
Product & Engineering Maturity
strongNo finding.
Security & Reliability Posture
adequateNone of the standard security guard rails are configured
adequateThere is no disclosure policy, no automated dependency updates, no named code owners and no pre-commit configuration. None of these is load-bearing on its own. Their collective absence says that security posture here is whatever the current team happens to remember to do, which is not a posture that survives the team changing.
| checked 5 kinds of guard rail across 3,661 tracked files; 0 present |
3 deserialisers that can run code
adequate3 places read data with a deserialiser that executes what it reads (Java object streams). That is safe on data the system wrote itself and remote code execution on anything else. Ask where each one's input comes from.
Android/dokit-leakcanary/src/main/java/com/squareup/leakcanary/AnalyzedHeap.java:45 — code-executing deserialiser |
Android/dokit-util/src/main/java/com/didichuxing/doraemonkit/util/ConvertUtils.java:327 — code-executing deserialiser |
Android/dokit/src/main/java/com/didichuxing/doraemonkit/util/DoKitCacheUtils.java:76 — code-executing deserialiser |
6 places insert HTML from a variable without sanitising it
adequate6 places set HTML from a value that is neither a literal nor passed through a sanitiser. Where the value can come from a user, that is stored cross-site scripting, and it is the first thing a buyer's security review looks for in a frontend.
Android/dokit/src/main/assets/h5help/dokit.js:1 — HTML from a variable |
Web/packages/web/src/plugins/console/log-detail.vue:6 — HTML from a variable |
Web/packages/web/src/plugins/console/log-item.vue:3 — HTML from a variable |
The app allows plain HTTP to any server
adequateThe app's manifest allows unencrypted HTTP app-wide (NSAllowsArbitraryLoads, or cleartext traffic permitted), rather than for named domains. Anything sent over plain HTTP can be read on the network, and enterprise security reviews ask about it. Some apps need it by nature (a podcast or feed reader fetches whatever URL a feed gives), so ask which case this is.
iOS/DoraemonKitDemo/DoraemonKitDemo/Info.plist:31 — cleartext allowed app-wide |
1 compiled library committed to the tree: OpenSSL
adequateThe product commits built copies of OpenSSL. They ship with it as vendored components, but no lockfile names their versions, so their published vulnerabilities were not checked. Ask which version each binary is, how it is rebuilt, and who watches its advisories.
Android/app/libs/arm64-v8a/libcrypto.so — committed binary |
Observability & Operations
not assessableNot rated: only 5 of 16 checks could reach a conclusion here; the rest do not apply to this repository or could not read it.
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on didi/dokit: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.