Read 2026-11-03
datalinkdc/dinky: technical due diligence, read from its repository
What Borehole read in datalinkdc/dinky's code and history at 0b426b3: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | adequate |
| Product & Engineering Maturity | adequate |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
- Releases are cut from another branch than the one surveyed
.gitmodules:1: 1 submodule(s) this survey does not read: .github/actions/translate-on-issue
Architecture & Codebase — including AI provenance
strongdinky-admin/src/main/resources/db/migration/postgresql/V20240506.1.0.2__baseline.sql is 4,090 lines, 51× this codebase's median file
adequateThe median source file here is 80 lines. 35 files exceed 1,000 lines, the largest being 4,090. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
dinky-admin/src/main/resources/db/migration/postgresql/V20240506.1.0.2__baseline.sql:1 — 4,090 lines (51× median) |
dinky-admin/src/main/resources/db/migration/h2/V20240506.1.0.2__baseline.sql:1 — 3,170 lines (39× median) |
dinky-web/src/components/Icons/WelcomeIcons.tsx:1 — 2,446 lines (30× median) |
dinky-admin/src/main/resources/db/migration/mysql/V20240506.1.0.2__baseline.sql:1 — 2,010 lines (25× median) |
dinky-client/dinky-client-1.20/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:1 — 1,808 lines (22× median) |
Engineering Process & SDLC Maturity
adequateTests cover a thin slice of the codebase
adequate117 test files against 1,979 source files (5.9%). This does not measure whether the tests are good, only whether enough of them exist for the codebase to be changed safely by someone who did not write it — which is exactly the situation after an acquisition.
| 117 test files / 1,979 source files |
Almost no process scaffolding exists in the repository
adequateOf five ordinary markers — CI workflows, CODEOWNERS, a pull-request template, pre-commit hooks, contribution guidance — 1 is present: CI workflows. Branch protection itself is a GitHub setting rather than a file, so this is a reading of proxies and not of the rules themselves. What it does establish is that the process is not written down anywhere a new engineer would find it.
| 1 of 5 markers present across 2,970 tracked files |
90 tests are switched off
adequate90 skip markers across 45 of 138 test files. Each is a failure somebody chose to stop seeing; the question is whether anyone is tracking them.
6% of recent commits change more than 2,000 lines
adequate12 of 216 commits in the last 24 months changed over 2,000 lines of code, not counting reformatting, renames, vendored or generated code. A change that size is rarely reviewed line by line. Ask how they were reviewed, and what made them that large.
| 12 commits over 2,000 lines |
Product & Engineering Maturity
adequate7% of bug fixes add or change a test
adequateOf 101 fixes in the last 24 months, 7 touched a test. A fix without the test that would have caught the bug can quietly come back, and the suite never learns from what went wrong.
| 7 of 101 |
11 files still carry code deprecated more than two years ago
adequate11 files were marked deprecated over two years ago and still are, the oldest since Mar 2023. A deprecation is a promise to remove. Ask what still depends on these, and whether removing them is scheduled.
dinky-admin/src/main/java/org/dinky/service/UserService.java — deprecated since Mar 2023 |
dinky-admin/src/main/java/org/dinky/service/TenantService.java — deprecated since Mar 2023 |
dinky-admin/src/main/java/org/dinky/service/AlertHistoryService.java — deprecated since Oct 2023 |
dinky-admin/src/main/java/org/dinky/service/DataBaseService.java — deprecated since Oct 2023 |
dinky-admin/src/main/java/org/dinky/service/JobInstanceService.java — deprecated since Oct 2023 |
Releases are cut from another branch than the one surveyed
adequateThe newest release, v1.2.5, is not on the branch this survey read; the newest release on it is v1.2.0. The shipped product may differ from what this report describes. Survey the release branch too.
| tag v1.2.5 |
Security & Reliability Posture
adequate118 dependencies float, and no lockfile is committed
adequateDependency versions are declared as ranges and no lockfile is committed, so a build today does not necessarily produce what a build last month produced. That matters twice over in a transaction: the thing being bought cannot be reproduced exactly, and a compromised upstream release arrives without anyone choosing to take it.
dinky-web/package.json:39 — ^0.3.5 |
dinky-web/package.json:40 — ^2.2.1 |
dinky-web/package.json:41 — ^5.3.7 |
dinky-web/package.json:42 — ^2.8.3 |
dinky-web/package.json:43 — ^2.6.3 |
1 Dockerfile runs the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
deploy/docker/Dockerfile — runs as root |
1 environment file is committed
adequatedeploy/docker/.env is tracked in git. Environment files are where credentials usually live, and committing one usually means nobody decided how secrets reach the running application. Whatever is in it is in the history for good. Check 05.1 says whether it holds anything credential-shaped.
deploy/docker/.env — committed environment file |
The build runs third-party code it does not pin
adequate12 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/add-assignees.yml:28 — action pinned by tag |
.github/workflows/auto-realease-ci.yml:134 — action pinned by tag |
3 SQL statements built from strings
adequate3 places in product code build SQL by formatting or joining strings rather than passing parameters. In each, what the code shows going in is a table or column name, a constant, or something the line does not show, not a request's value. Ask whether any value reaches these strings, rather than a parameter.
dinky-admin/src/main/java/org/flywaydb/core/internal/database/postgresql/PostgreSQLDatabase.java:47 — SQL built from a string |
dinky-client/dinky-client-base/src/main/java/org/dinky/trans/ddl/CreateAggTableOperation.java:55 — SQL built from a string |
dinky-connectors/dinky-connector-jdbc-1.14/src/main/java/org/apache/flink/connector/jdbc/dialect/SQLServerDialect.java:120 — SQL built from a string |
3 deserialisers that can run code
adequate3 places read data with a deserialiser that executes what it reads (Java object streams). That is safe on data the system wrote itself and remote code execution on anything else. Ask where each one's input comes from.
dinky-gateway/src/main/java/org/dinky/gateway/yarn/YarnGateway.java:527 — code-executing deserialiser |
dinky-sandbox/dinky-sandbox-base/src/main/java/org/dinky/sandbox/socket/SocketClient.java:60 — code-executing deserialiser |
dinky-sandbox/dinky-sandbox-base/src/main/java/org/dinky/sandbox/socket/SocketDataProcessor.java:58 — code-executing deserialiser |
5 advisories against this project in the last 24 months, 2 high or critical
adequateThe newest was published on 2026-08-06. A project that publishes advisories is telling its users about its fixes, and the count and pace say how much security work it carries. Whether 5 of them are fixed in the code you ship could not be told from this history: its version is only known to be at least 1.2.0. Answer lives in: the release you run, set against each fixed version.
| 2026-08-06: CVE-2026-70558 (critical): Dinky's POST /download/uploadFromRsByLocal handler passes the caller-supplied path parameter directly to new File(path) and file.transferTo(dest) with no path v |
| 2026-08-06: CVE-2026-70559 (high): Dinky's SysConfigController.getAll() handler for GET /api/sysConfig/getAll carries a method-level @SaIgnore annotation that short-circuits the class-level @SaCh |
| 2026-02-24: CVE-2026-3051 (low): A vulnerability has been found in DataLinkDC dinky up to 1.2.5. The affected element is the function getProjectDir of the file dinky-admin/src/main/java/org/din |
| 2026-02-24: CVE-2026-3052 (low): A vulnerability was found in DataLinkDC dinky up to 1.2.5. The impacted element is the function proxyUba of the file dinky-admin/src/main/java/org/dinky/control |
| 2026-02-24: CVE-2026-3053 (moderate): A vulnerability was determined in DataLinkDC dinky up to 1.2.5. This affects the function addInterceptors of the file dinky-admin/src/main/java/org/dinky/config |
Observability & Operations
adequateNo structured logging library is in use
adequateNothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.
| searched 2,792 files for 10 structured logging libraries; 0 matched |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on datalinkdc/dinky: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.