Read 2026-11-03
cherryhq/cherry-studio: technical due diligence, read from its repository
What Borehole read in cherryhq/cherry-studio's code and history at e2d1967: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | strong |
| Engineering Process & SDLC Maturity | adequate |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | strong |
| Fit with the Acquirer | not assessable |
What the repository says
- Releases are cut from another branch than the one surveyed
LICENSE: Relicensed: MIT → Apache-2.0 (2024-10-17) → Apache-2.0 with additional terms (2025-04-12) → AGPL-3.0 (2025-09-06)
Architecture & Codebase — including AI provenance
strongsrc/main/ai/agentSession/AgentSessionRuntimeService.ts is 3,682 lines, 47× this codebase's median file
adequateThe median source file here is 78 lines. 76 files exceed 1,000 lines, the largest being 3,682. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
src/main/ai/agentSession/AgentSessionRuntimeService.ts:1 — 3,682 lines (47× median) |
src/shared/utils/codeLanguages.ts:1 — 3,679 lines (47× median) |
src/main/services/binaryManager/BinaryManager.ts:1 — 2,609 lines (33× median) |
src/renderer/components/composer/ComposerSurfaceRuntime.tsx:1 — 2,525 lines (32× median) |
src/main/data/services/AgentSessionMessageService.ts:1 — 2,454 lines (31× median) |
Engineering Process & SDLC Maturity
adequateTests are retried until they pass
adequateThe suite is configured to retry failing tests (playwright.config.ts). A retry turns a flaky test green without saying why it failed, so a green build means the tests passed eventually. Ask how many retries a typical run needs, and which tests need them.
playwright.config.ts:27 — test retry |
6% of recent commits change more than 2,000 lines
adequate476 of 8158 commits in the last 24 months changed over 2,000 lines of code, not counting reformatting, renames, vendored or generated code. A change that size is rarely reviewed line by line. Ask how they were reviewed, and what made them that large.
| 476 commits over 2,000 lines |
Product & Engineering Maturity
strongReleases are cut from another branch than the one surveyed
adequateThe newest release, v2.1.10, is not on the branch this survey read; the newest release on it is v2.0.9. The shipped product may differ from what this report describes. Survey the release branch too.
| tag v2.1.10 |
Security & Reliability Posture
adequate2 credential-shaped strings in the tree sit in tests, examples, documentation or local development settings
adequateStrings shaped like credentials appear only where fakes are usual: test fixtures, examples, documentation, placeholders and local stacks. They are almost always fakes. Ask someone to confirm that none of them works anywhere, because a real key in a development file is still a real key. 2 other matchs set aside: expired tokens, licence tokens a vendor verifies with a public key, or placeholder text where a key would go. None grants access to anything.
| 2 cited: Slack token, where fakes are usual |
1 Dockerfile runs the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
native/external-app/linux/Dockerfile — runs as root |
The build runs third-party code it does not pin
adequate8 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
.github/workflows/auto-update-catalog.yml:31 — action pinned by tag |
.github/workflows/auto-update-catalog.yml:65 — action pinned by tag |
4 SQL statements built from strings
adequate4 places in product code build SQL by formatting or joining strings rather than passing parameters. 1 of them put a value into the string; in the rest, what the code shows going in is a table or column name, a constant, or something the line does not show. Ask whether any value reaches these strings, rather than a parameter.
src/main/features/knowledge/pipeline/vectorstore/indexStore/KnowledgeIndexStore.ts:506 — SQL built from a string |
src/main/features/knowledge/pipeline/vectorstore/indexStore/KnowledgeIndexStore.ts:478 — SQL built from a string |
src/main/features/knowledge/pipeline/vectorstore/indexStore/KnowledgeIndexStore.ts:552 — SQL built from a string |
3 shell commands built from strings
adequate3 places run a command through a shell (`shell=True`, `os.system`, `exec` with a template) rather than passing arguments. Where any part comes from outside, it is command injection. Ask where each one's input comes from.
src/main/services/OpenClawService.ts:959 — command run through a shell |
src/main/services/OpenClawService.ts:969 — command run through a shell |
src/main/services/OvmsManager.ts:173 — command run through a shell |
62 locked dependencies have published vulnerabilities, 39 high or critical in what ships
adequate62 of 3,011 locked dependencies match 160 published advisories in OSV, 63 of them rated high or critical. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version.
pnpm-lock.yaml — tar 6.2.1: GHSA-23hp-3jrh-7fpw (critical), fixed in 7.5.19 |
pnpm-lock.yaml — storybook 10.6.0: GHSA-f2ph-cmg5-wxc8 (critical), fixed in 10.6.2; a development dependency |
pnpm-lock.yaml — tinypool 2.1.0: GHSA-5gmw-xhrv-c9v3 (critical), fixed in 2.1.1; a development dependency |
7 places insert HTML from a variable without sanitising it
adequate7 places set HTML from a value that is neither a literal nor passed through a sanitiser. Where the value can come from a user, that is stored cross-site scripting, and it is the first thing a buyer's security review looks for in a frontend.
resources/skills/skill-creator/eval-viewer/viewer.html:849 — HTML from a variable |
resources/skills/skill-creator/eval-viewer/viewer.html:904 — HTML from a variable |
resources/skills/skill-creator/eval-viewer/viewer.html:1317 — HTML from a variable |
3 vendored components with no licence
adequateThird-party code is committed into this repository without any statement of the terms it arrived under. Unknown terms are harder to deal with than inconvenient ones: an awkward licence can be complied with, an absent one cannot. Each of these needs its origin established before the code changes hands.
src/renderer/assets/styles/vendor/katex.css — 1 tracked files, no licence file |
src/renderer/assets/styles/vendor/og-crd.css — 1 tracked files, no licence file |
src/renderer/assets/styles/vendor/xyflow.css — 1 tracked files, no licence file |
Relicensed: MIT → Apache-2.0 (2024-10-17) → Apache-2.0 with additional terms (2025-04-12) → AGPL-3.0 (2025-09-06)
adequateThe root licence changed 3 time(s). The latest terms restrict what users, hosts or a buyer may do in ways the earlier ones did not. Code taken under the old terms stays under them, so both matter in diligence.
5 advisories against this project in the last 24 months, 5 high or critical
adequateThe newest was published on 2026-07-15. A project that publishes advisories is telling its users about its fixes, and the count and pace say how much security work it carries. None of them affects the surveyed version.
| 2026-07-15: CVE-2026-40501 (high): Cherry Studio versions 1.2.2 through 1.9.12, fixed in commit 1518530, contain a remote code execution vulnerability in SearchService that allows remote attacker |
| 2025-10-10: GHSA-hh6w-rmjc-26f6 (critical), fixed in 1.6.4: One-click on a specific URL to cause a command to execute |
| 2025-08-11: GHSA-gjp6-9cvg-8w93 (critical), fixed in 1.5.2: Cherry Studio RCE Vulnerability Disclosure |
| 2025-08-11: GHSA-8xr5-732g-84px (critical), fixed in v1.5.2: Cherry Studio is Vulnerable to OS Command Injection during Connection with a Malicious MCP Server |
| 2025-08-11: GHSA-p6vw-w3p8-4g72 (critical), fixed in v1.5.1: One-click Remote Code Execution through Custom URL Handling in Cherry Studio v1.4.11 |
Observability & Operations
strongNo finding.
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on cherryhq/cherry-studio: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.