Read 2026-10-04
astral-sh/ruff: technical due diligence, read from its repository
What Borehole read in astral-sh/ruff's code and history at 7d73e4b: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.
| Dimension | Rating |
|---|---|
| Architecture & Codebase — including AI provenance | adequate |
| Engineering Process & SDLC Maturity | adequate |
| Product & Engineering Maturity | strong |
| Security & Reliability Posture | adequate |
| Observability & Operations | adequate |
| Fit with the Acquirer | not assessable |
What the repository says
.github/PULL_REQUEST_TEMPLATE.md:8: states a policy on AI-generated contributions
Architecture & Codebase — including AI provenance
adequatecrates/ty_python_semantic/src/types/infer/builder.rs is 13,223 lines, 264× this codebase's median file
adequateThe median source file here is 50 lines. 173 files exceed 1,000 lines, the largest being 13,223. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.
crates/ty_python_semantic/src/types/infer/builder.rs:1 — 13,223 lines (264× median) |
crates/ty_python_semantic/src/types.rs:1 — 12,373 lines (247× median) |
crates/ty_ide/src/completion.rs:1 — 11,796 lines (235× median) |
crates/ty_python_semantic/src/types/call/bind.rs:1 — 10,381 lines (207× median) |
crates/ty_ide/src/inlay_hints.rs:1 — 7,906 lines (158× median) |
1 base image floats: no version, or `latest`
adequate1 of 2 `FROM` lines in product Dockerfiles name an image without a version, or with `latest`. Each build pulls whatever the registry serves that day, so the image that ships can change without a commit, and last month's build cannot be reproduced. Pin a version, or a digest.
Dockerfile:1 — base image without a version |
Engineering Process & SDLC Maturity
adequateCI runs tests that cannot fail the build
adequate1 test command in CI ends in `|| true` or an equivalent, so the pipeline passes whatever the tests say. A green build then means the tests ran, not that they passed.
.github/workflows/ci.yaml:417 — a test command that cannot fail |
Product & Engineering Maturity
strong5 files still carry code deprecated more than two years ago
adequate5 files were marked deprecated over two years ago and still are, the oldest since Jul 2023. A deprecation is a promise to remove. Ask what still depends on these, and whether removing them is scheduled.
crates/ruff_python_stdlib/src/builtins.rs — deprecated since Jul 2023 |
crates/ruff_workspace/src/options.rs — deprecated since Oct 2023 |
crates/ruff_linter/src/rules/numpy/rules/numpy_2_0_deprecation.rs — deprecated since Nov 2023 |
crates/ruff_linter/src/rules/pycodestyle/rules/type_comparison.rs — deprecated since Nov 2023 |
crates/ruff_linter/src/rules/pylint/rules/invalid_index_return.rs — deprecated since Apr 2024 |
Security & Reliability Posture
adequate1 Dockerfile runs the application as root
adequateNo USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.
Dockerfile — runs as root |
The build runs third-party code it does not pin
adequate1 step pipes a download straight into a shell. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.
Dockerfile:21 — download piped into a shell |
6 locked dependencies have published vulnerabilities, 4 high or critical
adequate6 of 787 locked dependencies match 10 published advisories in OSV, 4 of them rated high or critical. A lockfile says which version is installed, not whether the flawed code is reachable from this product, so each needs a look. Most are fixed by an upgrade, and the advisory names the version. None of the high or critical ones is in what the product ships: they are development dependencies. This lockfile pins development tools alongside what ships and does not say which is which, so some of these may never reach a user.
uv.lock — anyio 4.14.1: GHSA-82r6-8w77-94w6 (critical), fixed in 4.14.2; a development dependency |
uv.lock — urllib3 2.7.0: GHSA-8988-9cw3-xx77 (high), fixed in 2.8.0; a development dependency |
Cargo.lock — rand 0.8.5: GHSA-cq8v-f236-94qc (low), fixed in 0.8.6 |
1 vendored component with no licence
adequateThird-party code is committed into this repository without any statement of the terms it arrived under. Unknown terms are harder to deal with than inconvenient ones: an awkward licence can be complied with, an absent one cannot. Each of these needs its origin established before the code changes hands.
crates/ruff_db/src/vendored/path.rs — 1 tracked files, no licence file |
Observability & Operations
adequateOne request cannot be followed through the logs
adequateNothing in the service carries a request or correlation id, and there is no tracing. When a customer reports a failure, the log lines that belong to their request cannot be picked out from everyone else's.
| no request id, correlation id or tracing found |
No error reporter is wired in
adequateNothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.
| no error reporter initialised |
Fit with the Acquirer
not assessableNot rated: structurally not assessable from a repository.
Read more, or read your own
The full report on astral-sh/ruff: every dimension, the questions for the room, and the audit log.
Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.