amphi-ai/amphi-etl: technical due diligence, read from its repository

The median source file here is 113 lines. 3 files exceed 1,130 lines, the largest being 1,456. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.

1,813 distinct 8-line blocks appear in two or more files. Copy-paste is the cheapest thing a generator does and among the more expensive things to inherit: a fix has to be applied everywhere the block landed, and nothing in the repository records where that is. Tests, fixtures and documentation examples are excluded — those repeat by design — so this is duplication in code that ships. Blocks are matched after normalising whitespace and only across different files.

Dependency versions are declared as ranges and no lockfile is committed, so a build today does not necessarily produce what a build last month produced. That matters twice over in a transaction: the thing being bought cannot be reproduced exactly, and a compromised upstream release arrives without anyone choosing to take it.

2 places in product code build SQL by formatting or joining strings rather than passing parameters. In each, what the code shows going in is a table or column name, a constant, or something the line does not show, not a request's value. Ask whether any value reaches these strings, rather than a parameter.

3 places run a command through a shell (`shell=True`, `os.system`, `exec` with a template) rather than passing arguments. Where any part comes from outside, it is command injection. Ask where each one's input comes from.

11 places set HTML from a value that is neither a literal nor passed through a sanitiser. Where the value can come from a user, that is stored cross-site scripting, and it is the first thing a buyer's security review looks for in a frontend.

LICENSE grants Elastic-2.0: source available, not open source; offering it as a managed service is not allowed. The reading comes from the licence's own title and clauses. Whether the terms fit the buyer's intended use, and whether any paid licence transfers with the code, is a question for counsel and the licensor.

Nothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.