Borehole · Project · free tier
1panel-dev/maxkb
Free reading: not for reliance
0c7dd35 · 7,578 commits · 2,204 files
Read 2026-11-03

1panel-dev/maxkb: technical due diligence, read from its repository

What Borehole read in 1panel-dev/maxkb's code and history at 0c7dd35: its licence, security advisories, releases, review practice, tests, dependencies and operations. Every finding cites the file and line it rests on. The full report also covers the team and asks the questions the code cannot answer.

DimensionRating
Architecture & Codebase — including AI provenancestrong
Engineering Process & SDLC Maturityadequate
Product & Engineering Maturityadequate
Security & Reliability Postureadequate
Observability & Operationsadequate
Fit with the Acquirernot assessable

Architecture & Codebase — including AI provenance

strong
01.6

apps/common/constants/permission_constants.py is 2,177 lines, 35× this codebase's median file

adequate

The median source file here is 62 lines. 14 files exceed 1,000 lines, the largest being 2,177. Size is not a defect on its own — some problems genuinely live in one place — but these are where merge conflicts, review fatigue and single-owner knowledge concentrate, and they are the first thing that slows an inheriting engineer down.

Evidence
apps/common/constants/permission_constants.py:1 — 2,177 lines (35× median)
apps/knowledge/serializers/document.py:1 — 1,967 lines (31× median)
apps/application/serializers/application.py:1 — 1,955 lines (31× median)
ui/src/views/document/index.vue:1 — 1,724 lines (27× median)
apps/knowledge/serializers/knowledge.py:1 — 1,601 lines (25× median)

Engineering Process & SDLC Maturity

adequate
02.3

Tests cover a thin slice of the codebase

adequate

16 test files against 1,897 source files (0.8%). This does not measure whether the tests are good, only whether enough of them exist for the codebase to be changed safely by someone who did not write it — which is exactly the situation after an acquisition.

Evidence
16 test files / 1,897 source files

Product & Engineering Maturity

adequate
04.19

1% of bug fixes add or change a test

adequate

Of 2667 fixes in the last 24 months, 15 touched a test. A fix without the test that would have caught the bug can quietly come back, and the suite never learns from what went wrong.

Evidence
15 of 2667

Security & Reliability Posture

adequate
05.3

68 dependencies float, and no lockfile is committed

adequate

Dependency versions are declared as ranges and no lockfile is committed, so a build today does not necessarily produce what a build last month produced. That matters twice over in a transaction: the thing being bought cannot be reproduced exactly, and a compromised upstream release arrives without anyone choosing to take it.

Evidence
ui/package.json:19 — ^0.3.1
ui/package.json:20 — ^6.0.1
ui/package.json:21 — ^6.2.1
ui/package.json:22 — ^6.1.2
ui/package.json:23 — ^2.10.5
05.6

1 Dockerfile runs the application as root

adequate

No USER instruction switches away from root, so the process runs with full privileges inside the container. It is a one-line fix and an ordinary expectation, which is why its absence is worth asking about: it usually says more about whether anyone has reviewed the deployment than about this container specifically.

Evidence
installer/Dockerfile — runs as root
05.25

2 environment files are committed

adequate

ui/env/.env, ui/env/.env.chat are tracked in git. Environment files are where credentials usually live, and committing one usually means nobody decided how secrets reach the running application. Whatever is in it is in the history for good. Check 05.1 says whether it holds anything credential-shaped.

Evidence
ui/env/.env — committed environment file
ui/env/.env.chat — committed environment file
05.27

The build runs third-party code it does not pin

adequate

8 third-party CI actions are referenced by a tag or branch rather than a commit, so they run whatever that tag points to on the day. Tags have been moved to malicious commits in real supply-chain attacks, and a piped script is whatever the server returns that minute. Pinning to a commit is the fix, and it is small.

05.13

13 outbound calls can wait forever

adequate

13 HTTP calls use a client with no timeout (Python `requests` without `timeout=`, or Go's default client). When a dependency slows down, each one holds a worker until the connection gives up, and enough of them take the service down with the dependency.

05.17

7 of 35 migrations cannot be rolled back

adequate

7 schema migrations (20%) have no working way back: an empty `downgrade`, a `down` that does nothing, or a data migration with no reverse. A bad deploy that includes one is recovered from a backup, not reverted. Ask when a restore was last rehearsed.

Evidence
apps/application/migrations/0001_initial.py:250 — migration with no way back
apps/application/migrations/0006_application_file_clean_time.py:23 — migration with no way back
apps/knowledge/migrations/0001_initial.py:180 — migration with no way back
05.21

5 shell commands built from strings

adequate

5 places run a command through a shell (`shell=True`, `os.system`, `exec` with a template) rather than passing arguments. Where any part comes from outside, it is command injection. Ask where each one's input comes from.

Evidence
apps/application/flow/tools.py:491 — command run through a shell
apps/common/utils/tool_code.py:63 — command run through a shell
apps/common/utils/tool_code.py:64 — command run through a shell
05.22

2 deserialisers that can run code

adequate

2 places read data with a deserialiser that executes what it reads (pickle). That is safe on data the system wrote itself and remote code execution on anything else. Ask where each one's input comes from.

Evidence
apps/common/utils/common.py:400 — code-executing deserialiser
apps/ops/celery/hmac_signed_serializer.py:27 — code-executing deserialiser
05.48

11 places insert HTML from a variable without sanitising it

adequate

11 places set HTML from a value that is neither a literal nor passed through a sanitiser. Where the value can come from a user, that is stored cross-site scripting, and it is the first thing a buyer's security review looks for in a frontend.

Evidence
apps/chat/template/embed.js:50 — HTML from a variable
apps/chat/template/embed.js:63 — HTML from a variable
apps/chat/template/embed.js:65 — HTML from a variable
05.65

61 advisories against this project in the last 24 months, 13 high or critical, 1 fixed in no release yet

adequate

The newest was published on 2026-10-16. A project that publishes advisories is telling its users about its fixes, and the count and pace say how much security work it carries. GHSA-2324-7xjr-9qxg (critical) affects 2.9.2, the newest release, and not the surveyed commit: its fix is in the surveyed commit and in no release. Answer lives in: the version you run. The record is incomplete: NVD: 2 records name maxkb with nothing tying them to this repository (CVE-2025-4546, CVE-2026-6108).

Evidence
2026-09-02: GHSA-2324-7xjr-9qxg (critical), fixed in the surveyed commit and in no release: MaxKB AWS Bedrock model credential injection leads to remote code execution
2026-10-16: GHSA-c4xr-7rr6-43mr (high), fixed in v2.10.7-lts: Eval Injection via Custom Tool "Init Param" Validator Rule Allows Arbitrary JavaScript Execution
2026-10-16: GHSA-f5c9-fpj5-jx9j (high), fixed in v2.10.7-lts: Path traversal in knowledge-base name leads to arbitrary .xlsx write and instance-wide import-template poisoning
2026-10-16: GHSA-8fqh-3q3c-qh7c (moderate), fixed in v2.10.7-lts: Account takeover
2026-10-16: GHSA-hcq6-r4hf-8hfg (moderate), fixed in v2.10.7-lts: Unauthenticated SSRF in chat file proxy via incomplete host denylist

Observability & Operations

adequate
06.1

No telemetry or error reporting is wired in anywhere

adequate

None of 2,004 readable files references an instrumentation, metrics or error-reporting library. If this system is in production, nobody learns that it broke from the system itself — they learn it from a customer. That is a reliability finding before it is an observability one.

Evidence
searched 2,004 tracked text files for 16 known instrumentation libraries; manifests for metrics, tracing and error-reporting families; locked dependencies for the packages that emit; 0 matched
06.2

No structured logging library is in use

adequate

Nothing references a structured logging library. Logs that are written to be read by a person are not searchable by a machine, which means incident response here is proportional to how well someone remembers the codebase rather than to what the tooling can find.

Evidence
searched 2,004 files for 10 structured logging libraries; 0 matched
06.9

No error reporter is wired in

adequate

Nothing in the service initialises an error reporter (Sentry, Rollbar, Bugsnag, Honeybadger or an APM agent). An exception in production reaches a person only if someone is reading the logs, which usually means a customer reports it first.

Evidence
no error reporter initialised

Fit with the Acquirer

not assessable

Not rated: structurally not assessable from a repository.

Read more, or read your own

The full report on 1panel-dev/maxkb: every dimension, the questions for the room, and the audit log.

Survey a repository: free on public repositories. Private code is read on your own machine by a collector whose source you can read first.